View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011793 | Dwarf Fortress | Dwarf Mode -- Trade | public | 2021-08-07 08:23 | 2024-03-07 05:28 |
| Reporter | Quietust | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | new | Resolution | open | ||
| Product Version | 0.47.05 | ||||
| Summary | 0011793: Caravans check pack_animal/wagon_puller biomes incorrectly? | ||||
| Description | When caravans arrive (or when the player first embarks), there appears to be logic to determine which creatures are appropriate for use as wagon pullers and pack animals, drawing from entity resources and filtering according to the local temperature and nearby biomes. However, the biome check appears to be examining the region tiles around (region_x,region_x) instead of the ones around (region_x,region_y), so if the player's fortress isn't along the diagonal, the animals in question may be filtered inappropriately. | ||||
| Additional Information | The function in question takes 8 parameters: a pair of int16 vectors to accept creature race/caste values, another pair of int16 vectors from which to draw race/caste values (typically from entity resources), min/max temperature values (taken from plotinfo), and the fortress's region X/Y coordinates. This dates back to at least 0.28.181.40d, where it also affected sieger mounts and minions. | ||||
| Tags | Probable Quick Fix | ||||
|
|
To be more specific, the bug is in the "pick_most_suited_animal" function, with it looping through Y coordinates `rx-1` thru `rx+1` (instead of `ry-1` thru `ry+1`). |
|
|
Judging from the patch notes ("Fixed issue in how environment-appropriate work animals are selected for visiting fortress"), this appears to have been fixed in verson 50.12. |
