View Issue Details

IDProjectCategoryView StatusLast Update
0003818Dwarf FortressLegends Mode -- History Exportpublic2010-12-24 04:01
ReporterMason11987 Assigned Touser11 
PrioritylowSeverityminorReproducibilityhave not tried
Status resolvedResolutionunable to reproduce 
Product Version0.31.18 
Summary0003818: Historical Figures don't appear in export, even with cull unimportant figures off
DescriptionSometimes after genning a world large amounts of historical figures won't be exported, even if cull unimportant figures is off (or if it's on).
Steps To ReproduceGen this world:


Created in DF v0.31.18.

[WORLD_GEN]
    [TITLE:LARGE REGION]
    [SEED:1770215885]
    [HISTORY_SEED:2028903343]
    [NAME_SEED:2789071286]
    [CREATURE_SEED:340806036]
    [DIM:257:257]
    [EMBARK_POINTS:1275]
    [END_YEAR:100]
    [BEAST_END_YEAR:300:80]
    [REVEAL_ALL_HISTORY:1]
    [CULL_HISTORICAL_FIGURES:0]
    [ELEVATION:1:400:800:800]
    [RAINFALL:0:100:400:400]
    [TEMPERATURE:25:75:400:400]
    [DRAINAGE:0:100:400:400]
    [VOLCANISM:0:100:400:400]
    [SAVAGERY:0:100:400:400]
    [ELEVATION_FREQUENCY:1:1:1:1:1:1]
    [RAIN_FREQUENCY:1:1:1:1:1:1]
    [DRAINAGE_FREQUENCY:1:1:1:1:1:1]
    [TEMPERATURE_FREQUENCY:1:1:1:1:1:1]
    [SAVAGERY_FREQUENCY:1:1:1:1:1:1]
    [VOLCANISM_FREQUENCY:1:1:1:1:1:1]
    [MEGABEAST_CAP:75]
    [SEMIMEGABEAST_CAP:150]
    [TITAN_NUMBER:33]
    [TITAN_ATTACK_TRIGGER:80:0:100000]
    [DEMON_NUMBER:52]
    [NIGHT_CREATURE_NUMBER:52]
    [GOOD_SQ_COUNTS:100:1000:2000]
    [EVIL_SQ_COUNTS:100:1000:2000]
    [PEAK_NUMBER_MIN:50]
    [PARTIAL_OCEAN_EDGE_MIN:2]
    [COMPLETE_OCEAN_EDGE_MIN:0]
    [VOLCANO_MIN:15]
    [REGION_COUNTS:SWAMP:1032:7:6]
    [REGION_COUNTS:DESERT:1032:7:6]
    [REGION_COUNTS:FOREST:4128:13:12]
    [REGION_COUNTS:MOUNTAINS:8256:9:9]
    [REGION_COUNTS:OCEAN:8256:7:6]
    [REGION_COUNTS:GLACIER:0:0:0]
    [REGION_COUNTS:TUNDRA:0:0:0]
    [REGION_COUNTS:GRASSLAND:8256:13:12]
    [REGION_COUNTS:HILLS:8256:13:12]
    [EROSION_CYCLE_COUNT:250]
    [RIVER_MINS:400:400]
    [PERIODICALLY_ERODE_EXTREMES:1]
    [OROGRAPHIC_PRECIPITATION:1]
    [SUBREGION_MAX:5000]
    [CAVERN_LAYER_COUNT:3]
    [CAVERN_LAYER_OPENNESS_MIN:0]
    [CAVERN_LAYER_OPENNESS_MAX:100]
    [CAVERN_LAYER_PASSAGE_DENSITY_MIN:0]
    [CAVERN_LAYER_PASSAGE_DENSITY_MAX:100]
    [CAVERN_LAYER_WATER_MIN:0]
    [CAVERN_LAYER_WATER_MAX:100]
    [HAVE_BOTTOM_LAYER_1:1]
    [HAVE_BOTTOM_LAYER_2:1]
    [LEVELS_ABOVE_GROUND:15]
    [LEVELS_ABOVE_LAYER_1:5]
    [LEVELS_ABOVE_LAYER_2:1]
    [LEVELS_ABOVE_LAYER_3:1]
    [LEVELS_ABOVE_LAYER_4:1]
    [LEVELS_ABOVE_LAYER_5:2]
    [LEVELS_AT_BOTTOM:1]
    [CAVE_MIN_SIZE:5]
    [CAVE_MAX_SIZE:25]
    [MOUNTAIN_CAVE_MIN:100]
    [NON_MOUNTAIN_CAVE_MIN:200]
    [ALL_CAVES_VISIBLE:0]
    [SHOW_EMBARK_TUNNEL:2]
    [TOTAL_CIV_NUMBER:300]
    [TOTAL_CIV_POPULATION:15000]
    [SITE_CAP:1500]
    [PLAYABLE_CIVILIZATION_REQUIRED:1]
    [ELEVATION_RANGES:8256:16512:8256]
    [RAIN_RANGES:8256:16512:8256]
    [DRAINAGE_RANGES:8256:16512:8256]
    [SAVAGERY_RANGES:8256:16512:8256]
    [VOLCANISM_RANGES:8256:16512:8256]


Export to xml

Find...

<historical_figures>
    <historical_figure>
        <id>9065</id>
TagsNo tags attached.

Activities

user6

2010-12-14 12:52

  ~0014588

How are you determining how many hist figs there should be? From Legends or what?

user11

2010-12-14 14:29

  ~0014590

World Gen, Hist Figs: 25256
Legends Mode, Historical Figures: 24541/25256

XML dump:
    <historical_figure>
        <id>34181</id>

Note that XML is an incomplete feature. Did your file finish loading? When I opened the dump, there was a significant delay.

Mason11987

2010-12-15 13:10

reporter   ~0014592

Footkerchief, the fact that they start at id 9065 means that 9000+ aren't being exported. In many world generations there will be tens of thousands of HF and every id is accounted for, in some there are many missing.

Dwarfu, I know that it's incomplete, but the cull unimportant figures options seems to suggest that they aren't culled if it's off, and yet some are, or at least for some reason not exported. That's why I thought it might be a bug.

user11

2010-12-15 14:40

  ~0014593

I see now, I didn't catch that you were showing the start of the file, not the end. My generation of your seed starts at ID 8926, but I have some modded megabeasts that would account for the difference.

I believe it may have to do with the beginning of world gen. I noticed a few times where it made it to placing civs, but eventually rejected the map. Those missing IDs are probably from those attempts, but are no longer necessary because the entire map was rejected. I don't think that any being in the final accepted map are unaccounted for.

user6

2010-12-16 09:14

  ~0014605

Those missing IDs are probably from those attempts, but are no longer necessary because the entire map was rejected.

Mason, does this account for what you're seeing? Do the IDs still start high when there are no world rejections?

Mason11987

2010-12-16 14:02

reporter   ~0014606

This I would have to check. If that's the case that sounds to me like a bug. I would hope that rejected would mean rejected. And there are never any entities/sites/civs/regions/ugregions/eventcollections/some others missing, so I'm skeptical of this.

Mason11987

2010-12-16 14:04

reporter   ~0014607

Also, sometimes these Historical figures are still associated with the world that comes out (they lead sides in battles, they are listed as kills, ect.) so they are definitely part of the final world.

user11

2010-12-16 14:41

  ~0014608

Show me. Post screenshots or empirical data that shows someone leading a battle or some other historical event that isn't in that xml dump.

I don't understand why you think ID numbers have to be contiguous. If those IDs weren't used in your world (as rejects), why would they be exported or even still exist? Just because the ID number (an index) keeps increasing, doesn't mean anything is missing.

Mason11987

2010-12-18 20:15

reporter   ~0014627

Went through checking some things out and writing this response when I realized that entities are sometimes missing too, so that's my mistake for saying that. But I would think sites would be missing on rejects too, no? Also, it doesn't appear there are ever any missing event collections (always starts on zero, as far as I can tell). That behavior just seemed inconsistent.

Also, I couldn't find any instance of histfigs being involved in other events, that's my mistake, I must have been viewing the xml files incorrectly when I saw that.

user11

2010-12-24 04:01

  ~0014689

Ok, thanks for the follow-up. If you do happen to come across some type of hist fig corruption, please reopen this report and post your findings.

Issue History

Date Modified Username Field Change
2010-12-14 11:42 Mason11987 New Issue
2010-12-14 12:52 user6 Note Added: 0014588
2010-12-14 14:29 user11 Note Added: 0014590
2010-12-14 21:38 user6 Tag Attached: AWAITING UPDATE
2010-12-15 13:10 Mason11987 Note Added: 0014592
2010-12-15 14:40 user11 Note Added: 0014593
2010-12-16 09:14 user6 Note Added: 0014605
2010-12-16 14:02 Mason11987 Note Added: 0014606
2010-12-16 14:04 Mason11987 Note Added: 0014607
2010-12-16 14:41 user11 Note Added: 0014608
2010-12-18 20:15 Mason11987 Note Added: 0014627
2010-12-24 04:00 user11 Tag Detached: AWAITING UPDATE
2010-12-24 04:01 user11 Note Added: 0014689
2010-12-24 04:01 user11 Status new => resolved
2010-12-24 04:01 user11 Resolution open => unable to reproduce
2010-12-24 04:01 user11 Assigned To => user11