View Issue Details

IDProjectCategoryView StatusLast Update
0011298Dwarf FortressLegends Mode -- History Exportpublic2020-02-04 18:14
ReporterKromtec Assigned ToToady One  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.47.01 
Fixed in Version0.47.02 
Summary0011298: XML Export of some new events does not include their type
DescriptionSome of the new events do not contain a <type> node, what makes them impossible to classify.

Examples:
    <historical_event>
        <id>596</id>
        <year>3</year>
        <seconds72>100800</seconds72>
        <initiating_enid>90</initiating_enid>
        <joining_enid>72</joining_enid>
        <joining_enid>82</joining_enid>
    </historical_event>

    <historical_event>
        <id>8720</id>
        <year>42</year>
        <seconds72>394800</seconds72>
        <speaker_hfid>1509</speaker_hfid>
        <site_hfid>10</site_hfid>
        <topic>set entity 1 against entity 2</topic>
        <entity_1>155</entity_1>
        <entity_2>153</entity_2>
    </historical_event>

Steps To ReproduceGenerate the legends XML export with version 0.47.01
TagsNo tags attached.

Activities

therahedwig

2020-02-03 07:52

reporter   ~0039826

There's also:

<historical_event>
    <id>29091</id>
    <year>44</year>
    <seconds72>226800</seconds72>
    <entity_id>546</entity_id>
    <reason>lack of funds</reason>
</historical_event>

(also note ransomer/ransomed being the same)
<historical_event>
    <id>349282</id>
    <year>143</year>
    <seconds72>134400</seconds72>
    <ransomed_hfid>27798</ransomed_hfid>
    <ransomer_hfid>27798</ransomer_hfid>
    <payer_hfid>22999</payer_hfid>
    <moved_to_site_id>251</moved_to_site_id>
</historical_event>

<historical_event>
        <id>501209</id>
        <year>181</year>
        <seconds72>0</seconds72>
        <site_id>572</site_id>
        <building_profile_id>6</building_profile_id>
        <acquirer_hfid>17781</acquirer_hfid>
        <purchased_unowned/>
        <inherited/>
        <rebuilt_ruined/>
</historical_event>

<historical_event>
        <id>76574</id>
        <year>73</year>
        <seconds72>109200</seconds72>
        <site_id>332</site_id>
        <structure_id>2</structure_id>
        <modifier_hfid>10355</modifier_hfid>
        <modification>dungeon</modification>
</historical_event>

<historical_event>
        <id>721427</id>
        <year>239</year>
        <seconds72>92400</seconds72>
        <enslaved_hfid>17680</enslaved_hfid>
        <seller_hfid>18417</seller_hfid>
        <payer_entity_id>2996</payer_entity_id>
        <moved_to_site_id>638</moved_to_site_id>
</historical_event>

For some of these it's obvious what they are, but having no type still makes it troublesome.

Issue History

Date Modified Username Field Change
2020-02-02 23:48 Kromtec New Issue
2020-02-03 07:52 therahedwig Note Added: 0039826
2020-02-04 18:14 Toady One Status new => resolved
2020-02-04 18:14 Toady One Fixed in Version => Next Version
2020-02-04 18:14 Toady One Resolution open => fixed
2020-02-04 18:14 Toady One Assigned To => Toady One