View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001332Dwarf FortressDwarf Mode -- Buildings, Generalpublic2010-04-19 07:402014-01-17 10:03
Reporterray10k Assigned ToToady One  
PrioritynoneSeveritytrivialReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformPCOSWindows XPOS VersionSP3
Product Version0.31.03 
Fixed in Version0.34.02 
Summary0001332: Olivine doors look like gems
DescriptionI had one room with a masterwork door. instead of a normal door, it appeared as a "masterwork"-sign.
Steps To Reproduce1: make a masterwork stone door. (my version used olivine)
2: build door
Additional InformationI actually kind of like the way it looks, and wouldn't mind if this turned out to be a feature.
Tagsbinary patch, door

Relationships

has duplicate 0001962 closeduser6 built olivine door looks like a rough hewn gem 
related to 0002589 resolvedToady One Metal doors look like wood/stone doors after being placed. 
related to 0003099 resolvedToady One Metal cages/floodgates/etc. show up with colors backwards 

Activities

smjjames

2010-04-19 08:09

reporter   ~0004229

It might be a graphical thing, are you using any graphics pack or is that vanilla DF?

user6

2010-04-19 09:45

  ~0004240

Doors have historically had display problems:
http://www.bay12games.com/forum/index.php?topic=20917.0
http://www.bay12games.com/forum/index.php?topic=47756.0

I'm not sure if display issues tied to quality are new or not. Did you try building a couple more (non-masterwork) olivine doors to see how they showed up?

ray10k

2010-04-20 03:35

reporter   ~0004322

I did build a lot of non-masterwork doors, all of them just showed up like normal doors.

tel

2010-04-20 10:06

reporter   ~0004345

This seems to be an issue with olivine doors in general. All of my (non-masterwork) olivine doors look normal when stored, but like gems when installed. They work fine as doors, though.

slink

2010-04-23 08:47

reporter   ~0004717

Last edited: 2010-04-23 08:47

 Same here. When installed, all olivine doors appear different from all the other doors, regardless of quality. No graphics pack here.

user6

2010-04-23 10:19

  ~0004731

Thanks for the info. I updated the summary accordingly.

Quietust

2010-05-18 19:17

reporter   ~0006988

I've heard of (artifact) GEM doors appearing like gems, but not olivine...

JeffGroves

2010-05-19 01:16

reporter   ~0007007

Confirmed to still be an issue in 31.04. Olivine doors still look like gems.

sirbruce

2010-06-20 18:05

reporter   ~0008819

Confirmed in 31.06 and 31.08 from a 31.05 savegame.

Kanddak

2010-07-14 15:25

reporter   ~0010257

Last edited: 2010-07-14 15:25

 Having this in 0.31.10, new game started today in .10 install with nothing changed except init files (in various ways) and keybindings (to work around MacOS X delete key -> mountain character bug). Olivine doors look like webs/gems/gears, other doors appear normal. Nothing seems unusual about the raw entry for olivine.

Quietust

2010-07-14 17:15

reporter   ~0010261

I just tried making doors out of every stone type I could bring with a test embark (everything but siltstone, shale, claystone, dolomite, chalk, talc, obsidian, raw adamantine, and slade), and olivine was the *only* one that appeared as "☼" (gray foreground, green background); all of the others appeared as "┼" (with the appropriate colors).

Quietust

2010-08-25 07:41

reporter   ~0012079

And now, in my current fortress in 0.31.12, I've built several olivine doors, but all of them appear as normal doors...

krenshala

2010-10-01 19:26

reporter   ~0013110

Just to add to this one, I'm running 0.31.14 and all five (5) of my olivine doors, none of which are masterwork, look normal in a stockpile but use the masterwork/raw-gem symbol when constructed. The doors work properly, so it just looks odd.

WinXP, 0.31.14 using the Phoebus Graphics Set, if it matters (though Phoebus says he doesn't think its anything he's changed in the configs).

krenshala

2010-10-07 17:27

reporter   ~0013246

Last edited: 2010-10-08 20:24

 And to add a new update, in 0.31.16 olivine doors appear to be working correctly (showing the normal rock door symbol both in stockpiles and when constructed) for me.

[edit] damn, started a new 0.31.16 fort and olivine doors have gone back to looking like gems/masterwork symbol when constructed. This time it was next to an olivine wall, and I do not believe that was the case when I got the doors that appeared 'normal' earlier in this comment.

Quietust

2011-08-19 08:47

reporter   ~0018577

Last edited: 2011-08-19 08:52

 A recently-posted movie on DFMA (http://mkv25.net/dfma/movie-2360) illustrates doors made of rose gold exhibiting this problem, and I've personally confirmed this with a vanilla test fortress in version 0.31.25.

Quietust

2011-11-25 15:01

reporter   ~0019034

Last edited: 2011-11-25 15:02

 With a bit of debugging, I've managed to locate the source of this problem: it's exactly the same as the problem in 0001498, a function/macro being called with its parameters in the wrong order, resulting in doors being displayed as ☼ if the Nth material (where N is the inorganic material ID, 0/1/2/etc for IRON/COPPER/SILVER/etc) belong to creature 31 (BIRD_GUINEAFOWL) is made of BONE.

The following binary patch (for Win32 DF 0.31.25 SDL) will fix the display of gem doors:

0x056E42 : 00 B8 30 -> 30 BA 00
0x056E48 : 66 -> 90
0x056E4A : D5 -> C5

(push 00 | mov eax,00000030 | mov dx,bp -> push 30 | mov edx,00000000 | nop | mov eax,ebp)

Note that this does NOT correct the problem of metal doors failing to display as ╪, as this is seemingly due to the code being missing altogether.

Quietust

2012-02-01 10:15

reporter   ~0019448

Binary patch for version 0.31.25 Linux: (untested)
44069 : 0C -> 04
44071 : 04 -> 08
4407C : 08 -> 0C

Quietust

2012-02-16 09:09

reporter   ~0019805

Still broken in version 0.34.01 - while exploring a law-giver's keep, I found a rose gold door that looked like a gem.

Toady One

2012-02-16 16:35

administrator   ~0019861

Sorted for next time. Thanks Quietust!

Issue History

Date Modified Username Field Change
2010-04-19 07:40 ray10k New Issue
2010-04-19 08:09 smjjames Note Added: 0004229
2010-04-19 09:45 user6 Note Added: 0004240
2010-04-19 10:02 Kennel Tag Attached: door
2010-04-20 03:35 ray10k Note Added: 0004322
2010-04-20 10:06 tel Note Added: 0004345
2010-04-23 08:47 slink Note Added: 0004717
2010-04-23 08:47 slink Note Edited: 0004717
2010-04-23 10:19 user6 Summary masterwork door looks different => Olivine doors look like gems
2010-04-23 10:19 user6 Note Added: 0004731
2010-05-18 19:14 user6 Relationship added has duplicate 0001962
2010-05-18 19:17 Quietust Note Added: 0006988
2010-05-19 01:16 JeffGroves Note Added: 0007007
2010-06-20 18:05 sirbruce Note Added: 0008819
2010-07-14 15:25 Kanddak Note Added: 0010257
2010-07-14 15:25 Kanddak Note Edited: 0010257
2010-07-14 17:15 Quietust Note Added: 0010261
2010-07-31 11:41 user6 Relationship added related to 0002589
2010-08-25 07:41 Quietust Note Added: 0012079
2010-10-01 19:26 krenshala Note Added: 0013110
2010-10-07 17:27 krenshala Note Added: 0013246
2010-10-08 20:24 krenshala Note Edited: 0013246
2011-08-19 08:47 Quietust Note Added: 0018577
2011-08-19 08:52 Quietust Note Edited: 0018577
2011-11-25 15:01 Quietust Note Added: 0019034
2011-11-25 15:01 Quietust Note Edited: 0019034
2011-11-25 15:02 Quietust Note Edited: 0019034
2011-11-25 19:55 Quietust Tag Attached: binary patch
2012-01-10 18:25 user6 Relationship added related to 0003099
2012-02-01 10:15 Quietust Note Added: 0019448
2012-02-16 09:09 Quietust Note Added: 0019805
2012-02-16 16:35 Toady One Note Added: 0019861
2012-02-16 16:35 Toady One Status new => resolved
2012-02-16 16:35 Toady One Fixed in Version => Next Version
2012-02-16 16:35 Toady One Resolution open => fixed
2012-02-16 16:35 Toady One Assigned To => Toady One