View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002238 | Dwarf Fortress | General | public | 2010-06-09 21:24 | 2010-07-09 21:06 |
| Reporter | MrWiggles | Assigned To | Baughn | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | 17 iMac G4 | OS | OSX | OS Version | 10.4.11 |
| Product Version | 0.31.06 | ||||
| Fixed in Version | 0.31.09 | ||||
| Summary | 0002238: Full screen mode on PPC Mac is a shade of yellow, except where green normally. - OSX | ||||
| Description | Full screen mode on PPC Mac is a shade of yellow, except where green normally. | ||||
| Steps To Reproduce | This does not happen in Intel Macs, 10.5. | ||||
| Additional Information | This does not happen in Intel Macs, 10.5. | ||||
| Tags | SDL-only | ||||
|
|
Do you have any screenshots of this problem? What PRINT_MODE are you using? Have you tried updating your graphics drivers? |
|
|
http://s296.photobucket.com/albums/mm198/aliceingorelandpictures/?action=view¤t=Picture7.png And water is also invisible. Driver updates is a none issue for Macs largely. [PRINT_MODE:2D] |
|
|
Do you get the same effect when zooming in windowed mode? If so it's probably the scaling code at fault. |
|
|
Do you still get this problem if you change the PRINT_MODE? |
|
|
Reminder sent to: MrWiggles Do you get the same effect when zooming in windowed mode? Do you still get this problem if you change the PRINT_MODE? |
|
|
When zooming in window mode while under 2D, no the issues does not happen. Switching to 2DSW seem to have fixed the issue. |
|
|
I think I see the problem. When creating a tile, the 2D HW renderer calls SDL_CreateRGBSurface() with SDL_HWSURFACE and expects the returned surface to have the pixel format specified. However looking at the actual SDL code, it seems that when SDL_HWSURFACE is specified, the pixel format of the actual screen is used, not the one specified in the call. (The manpage actually contradicts this, you need to look at the SDL code itself) Presumably on this particular PPC hardware, the underlying screen format in fullscreen mode is then something other than the RGBA layout that the tile renderer expects. I'm not sure quite why we're requesting a HW surface there anyway: the code calls SDL_DisplayFormat (via SDL_Resize) on the returned surface eventually, which should return a HW surface where appropriate anyway. Maybe the fix is to just always initially create a SW surface for tiles, regardless of the 2D vs. 2DSW setting. |
|
|
I've put a patch which makes this change at http://s3test.randomly.org/df/2238/dflibgraphics-2drenderer-use-swsurface.txt It makes no difference on my Linux system, so at least it doesn't break anything. Performance is unchanged, but 2D and 2DSW performance are essentially identical on my system anyway. Unfortunately I don't have an OSX environment to build/test on. |
|
|
If willing to provide instructions, I'd give it a go. |
|
|
Setting HWSURFACE (and that entire branch) is legacy code from before we used a resizer. I've taken care of it. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-06-09 21:24 | MrWiggles | New Issue | |
| 2010-06-21 12:04 |
|
Note Added: 0008888 | |
| 2010-06-21 12:04 |
|
Tag Attached: AWAITING UPDATE | |
| 2010-06-21 12:07 |
|
Tag Attached: SDL-only | |
| 2010-06-28 01:06 | MrWiggles | Note Added: 0009204 | |
| 2010-06-28 02:47 | oliver | Note Added: 0009207 | |
| 2010-06-28 05:50 |
|
Note Added: 0009209 | |
| 2010-06-30 13:11 |
|
Note Added: 0009399 | |
| 2010-06-30 23:51 | MrWiggles | Note Added: 0009448 | |
| 2010-07-01 00:31 | oliver | Note Added: 0009449 | |
| 2010-07-01 07:00 |
|
Tag Detached: AWAITING UPDATE | |
| 2010-07-02 20:04 | oliver | Note Added: 0009555 | |
| 2010-07-03 02:55 | MrWiggles | Note Added: 0009564 | |
| 2010-07-06 08:28 | Baughn | Note Added: 0009684 | |
| 2010-07-06 08:28 | Baughn | Status | new => resolved |
| 2010-07-06 08:28 | Baughn | Fixed in Version | => 0.31.09 |
| 2010-07-06 08:28 | Baughn | Resolution | open => fixed |
| 2010-07-06 08:28 | Baughn | Assigned To | => Baughn |
