View Issue Details

IDProjectCategoryView StatusLast Update
0003670Dwarf FortressDwarf Mode -- Jobs, Animal Handlingpublic2022-03-08 06:20
ReporterKhym Chanur Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
Status newResolutionopen 
Platformx86 (AMD Athlon 7550 Dual-Core)OSMandriva OneOS Version2010 (2.6.31.5)
Product Version0.31.18 
Summary0003670: Can't milk tamed purring maggots
DescriptionLike in 40d, tamed purring maggots can't be milked.
TagsNo tags attached.

Activities

Quietust

2022-03-08 06:20

reporter   ~0041231

Back in version 0.23, there were at least 3 reasons why pets could not be milked:
1. The job code for "Milk Creature" only searches within the set of "cookable" items, and Pets aren't included in that list.
2. When examining the contents of a Cage or Animal Trap, the Milk Creature job explicitly checks that it contains a VERMIN item.
3. The "isMilkable" vmethod for `item_petst` simply does "return false;", compared to the version for `item_verminst` which checks Kitchen settings and also verifies that the vermin has the MILKABLE flag and hasn't been milked recently.

On the other hand:
1. The "has been milked recently" variable is part of the `item_critterst` base class, making it available to both VERMIN and PET items.
2. The Milk Creature job code actually checks for both VERMIN and PET items in addition to cages and animal traps.

Thus, it sounds like Toady might have planned for tamed purring maggots to be milkable at one point but then changed his mind. That, or he intended to add it but got distracted before he could finish implementing (and testing) it.

Add Note

Note

Issue History

Date Modified Username Field Change
2010-11-19 02:24 Khym Chanur New Issue
2022-03-08 06:20 Quietust Note Added: 0041231