View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003759Dwarf FortressDwarf Mode -- Tradepublic2010-11-30 13:482014-07-23 10:18
ReporterVideospirit Assigned ToToady One  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version0.31.18 
Fixed in Version0.40.05 
Summary0003759: Dwarven caravan brought silver crossbow, ITEMS_WEAPON_RANGED ignored in world gen?
DescriptionA while back I purchased myself a -silver crossbow- off of the dwarven caravan, I probably shouldn't have been able to do that.
Steps To ReproduceReload the game just before the caravan arrives over and over again, the year after requesting crossbows, if it's not a world specific issue it should happen eventually.
Additional InformationIt's just been laying around in a weapons stockpile the whole time. I haven't actually tried seeing if it works any better in melee than your standard crossbow, or if the thing even works although I don't see why it wouldn't, my Artifact Tin crossbow sure does.
Tagsbinary patch

Activities

user6

2010-11-30 13:53

  ~0014319

Last edited: 2010-11-30 13:53

 Are you using any mods? What version was the world generated in?

Videospirit

2010-11-30 18:49

reporter   ~0014326

It was generated in 0.31.18, I tweaked a few things in the raws but I doubt they'd effect this issue.

My Changes: Tweaked dwarven soul to prevent stat decay and make all stats better in general, especially agility.
Added Longskirts to goblins and made them common for elves(added chausses to goblins too but they seem to prefer their socks, will remove their ability to make socks next time I make a world)
Gave Elves evil plants, and evil and underground wood tokens.
Removed unremarkable stone layers(a lot of them) and all soil layers that were not sand or ocean bottom layers to make site finding easier.
Made Glumprong and sliver barb [Wet][Dry][Evil]
That should be all of them


I think it was the very first caravan this fort welcomed that brought the crossbow, it was shortly before I started reporting bugs on here and I forgot to mention it until earlier today. It's still sitting in the stockpile if you know of some place I can upload the save.

user6

2010-11-30 19:38

  ~0014328

You can upload to http://dffd.wimbli.com/

Did you make those changes before or after generating the world? Do you have any hidden backup files cluttering your raws folder, like in 0001428?

Videospirit

2010-11-30 20:10

reporter   ~0014330

Those changes were made before generating the world, I can't find any hidden files but I'm not actually sure where to turn the preferences to show them instead of hide them are for vista.

http://dffd.wimbli.com/file.php?id=3505 save is here.

assaultdoor

2011-03-15 00:19

reporter   ~0016262

Last edited: 2011-03-15 00:21

 If it helps, I just saw a human caravan carrying a -silver crossbow- and a silver bow. I'm using vanilla raws.

Infiltrator

2011-03-15 04:54

reporter   ~0016266

I'm pretty sure I've seen silver crossbows too. I'm not at my desktop now, so I can't check. However, if the save still has the silver crossbow, I'll upload it.

Videospirit

2012-04-02 16:04

reporter   ~0022045

I just had this happen again in the latest version, so it's definately still a thing.

Quietust

2012-08-02 12:20

reporter   ~0023397

Last edited: 2012-08-02 12:24

 While looking at a disassembly of the code used to create caravan items (in order to better understand how the game keeps track of what materials entities can use), I found the part that creates weapons and noticed an error in the logic - it checks whether or not the weapon is ranged to determine the type of material to use, but the check is backwards, so ranged weapons draw from the "melee weapon material" list (which includes silver, and is also used for trap components) and melee weapons draw from the "ranged weapon material" list (which does not include silver).

In other words, this bug not only permits caravans to bring ranged weapons made of silver but also prevents them from bringing melee weapons made of silver.

The following binary patch should fix this problem in Win32 v0.34.11 SDL:
0x4AA9F5 : 74 -> 75

Issue History

Date Modified Username Field Change
2010-11-30 13:48 Videospirit New Issue
2010-11-30 13:53 user6 Note Added: 0014319
2010-11-30 13:53 user6 Note Edited: 0014319
2010-11-30 13:54 user6 Summary Dwarven Caravan brought Silver Crossbow => Dwarven caravan brought silver crossbow, ITEMS_WEAPON_RANGED ignored in world gen?
2010-11-30 13:54 user6 Tag Attached: AWAITING UPDATE
2010-11-30 18:49 Videospirit Note Added: 0014326
2010-11-30 19:38 user6 Note Added: 0014328
2010-11-30 20:10 Videospirit Note Added: 0014330
2011-03-15 00:19 assaultdoor Note Added: 0016262
2011-03-15 00:21 assaultdoor Note Edited: 0016262
2011-03-15 04:54 Infiltrator Note Added: 0016266
2012-04-02 16:04 Videospirit Note Added: 0022045
2012-04-02 17:51 user6 Tag Detached: AWAITING UPDATE
2012-08-02 12:20 Quietust Note Added: 0023397
2012-08-02 12:22 Quietust Note Edited: 0023397
2012-08-02 12:24 Quietust Note Edited: 0023397
2012-08-02 12:24 Quietust Tag Attached: binary patch
2014-03-25 13:09 user11 Assigned To => user11
2014-03-25 13:09 user11 Status new => acknowledged
2014-07-23 10:18 Toady One Status acknowledged => resolved
2014-07-23 10:18 Toady One Fixed in Version => Next Version
2014-07-23 10:18 Toady One Resolution open => fixed
2014-07-23 10:18 Toady One Assigned To user11 => Toady One