0003766: Patrol routes don't work if they include the same waypoint multiple times

ID	Project	Category	View Status	Date Submitted	Last Update

0003766	Dwarf Fortress	Dwarf Mode -- Jobs, Military	public	2010-12-02 07:33	2014-08-04 14:54

Reporter	Ogg the Blinky Sock	Assigned To
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	new	Resolution	open
Platform	iMac Intel	OS	OS X w/ Wine	OS Version	10.6.5
Product Version	0.31.18

Summary	0003766: Patrol routes don't work if they include the same waypoint multiple times
Description	I made a patrol route to send dwarves out and back along my eastern road. The sequence of waypoints was in an "A -> B -> C -> D -> C -> B -> A " format, out and back. The dwarves would become trapped between points 'C' and 'D', always returning to 'D' from 'C', rather than continuing to 'B'.
Additional Information	Verified by observing that the desired patrol behaviour occurs along a "A -> B -> C -> D -> E -> F -> A" route where 'E' and 'F' are placed right beside 'B' and 'C', respectively.
Tags	patrol, route, waypoint

~~user6~~ 2010-12-02 07:53 ~0014363	Unless you've confirmed that this bug can be reproduced in any fortress (not just the one you're playing), please upload a save demonstrating this problem to http://dffd.wimbli.com/

Ogg the Blinky Sock 2010-12-02 15:54 reporter ~0014377	I've just confirmed this effect by marching seven pristine starting dwarves on an "A -> B -> C -> D -> C -> B -> A" route consisting of four points (ABCD) in a straight line, on level ground. So it would appear to be reproducible when running my computer setup, at least. The likelihood of it being a Wine-specific error, though, is probably kinda small.

Quietust 2010-12-02 16:20 reporter ~0014378	It's probably not keeping track of the index of the squad's current waypoint on their patrol, but just searching for the waypoint itself within the route to figure out where to go next (i.e. "Whether I came from B or D, I'm currently at C, and the path is A-B-C-D-C-B-A, so my destination is D"); thus, any patrol route that doubles back at any point would do this.

zupkuck 2014-08-04 14:52 reporter ~0028316	I noticed this in a .34-era fort of mine that had re-used waypoints, will see if I can dig up the save. The patrolling dwarves would bug out and just walk back and forth between two points.

Note

Date Modified	Username	Field	Change
2010-12-02 07:33	Ogg the Blinky Sock	New Issue
2010-12-02 07:53	~~user6~~	Note Added: 0014363
2010-12-02 07:54	~~user6~~	Summary	Patrol routes implemented incorrectly. => Patrol routes don't work if they include the same waypoint multiple times
2010-12-02 15:54	Ogg the Blinky Sock	Note Added: 0014377
2010-12-02 15:55	Ogg the Blinky Sock	Tag Attached: route
2010-12-02 15:55	Ogg the Blinky Sock	Tag Attached: patrol
2010-12-02 15:55	Ogg the Blinky Sock	Tag Attached: waypoint
2010-12-02 16:20	Quietust	Note Added: 0014378
2014-08-04 14:52	zupkuck	Note Added: 0028316