View Issue Details

IDProjectCategoryView StatusLast Update
0000404Dwarf FortressLegends Mode -- History Exportpublic2010-12-09 17:38
Reporterjfs Assigned ToToady One  
PrioritylowSeveritymajorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version0.31.01 
Fixed in Version0.31.13 
Summary0000404: Legends XML export produces malformed XML
DescriptionThe XML file exported from Legends mode is illegal/not well-formed.
XML files must have a single top-level element that is parent of everything else. The file produced by DF has multiple elements at the top level, for example "regions", "underground_regions" and "sites" are all elements at top level.

The solution will be to wrap everything (except the <?xml?> prologue) inside a single top-level element, such as <world></world>.

I believe most XML parsers will bail on the file as it is now. (At least MSXML does: Try opening the file in Internet Explorer and scroll to the bottom, where you should see an error message.)
Additional InformationSee XML 1.0 recommendation section 2.1: http://www.w3.org/TR/xml/#sec-well-formed
Tagslegends, RESOLVED

Activities

SirPenguin

2010-04-04 18:32

reporter   ~0000971

Just wanted to confirm this, though of course he did say that the feature was unfinished.

jfs

2010-05-01 16:21

reporter   ~0005861

Just checked, this is still an issue in 0.31.03. Tested with a freshly generated pocket region.

smjjames

2010-05-01 17:37

reporter   ~0005868

Yea, Toady said that the export to xml isn't actually working yet.

user1294

2010-09-27 05:09

  ~0013020

As of 31.13, the exported xml has a wrapping <df_world> </df_world> element.

jfs

2010-10-08 10:13

reporter   ~0013264

I can confirm that this bug is fixed.

Issue History

Date Modified Username Field Change
2010-04-04 08:45 jfs New Issue
2010-04-04 17:25 Qloos Tag Attached: legends
2010-04-04 18:32 SirPenguin Note Added: 0000971
2010-05-01 16:21 jfs Note Added: 0005861
2010-05-01 17:37 smjjames Note Added: 0005868
2010-09-27 05:09 user1294 Note Added: 0013020
2010-10-08 10:13 jfs Note Added: 0013264
2010-10-08 10:13 jfs Tag Attached: RESOLVED
2010-12-09 17:38 user6 Status new => resolved
2010-12-09 17:38 user6 Fixed in Version => 0.31.13
2010-12-09 17:38 user6 Resolution open => fixed
2010-12-09 17:38 user6 Assigned To => Toady One