View Issue Details

IDProjectCategoryView StatusLast Update
0005050Dwarf FortressTechnical -- Renderingpublic2012-02-23 15:02
ReporterGreendogo Assigned ToBaughn  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.34.01 
Fixed in Version0.34.03 
Summary0005050: Adv Mode "get" menu not refreshing properly with TrueType
DescriptionWhen you open the Get/Ground menu changing the page using / or * will leave an image of the previous page's text behind the newly brought up page. This makes it slightly difficult to view and distinguish menu items as all the text is running together.

This isn't a problem in corners of rooms or other times when you don't have the option of changing "Get/Ground" menu pages.

This may affect other menus that float over the game world view, meaning that menus like the inventory and interact menus don't have this issue.
Steps To ReproduceCreate an adventurer and push the "g" button to open the "Get/Ground" menu in place where the menu would have multiple pages and then use "/" or "*" to change the page. You should notice the ghosting of the previous page "under" or behind the new page's contents.
Additional InformationI tested this with multiple character in DF version 0.34.01
TagsNo tags attached.

Activities

Greendogo

2012-02-14 04:15

reporter   ~0019498

Last edited: 2012-02-14 04:20

I discovered new information. When you change the zoom using the mouse wheel so that the "Get/Ground" menu appears in the upper left instead of the lower left portion of the screen the visual error described above happens.
However, zooming out so that you can see more of your surroundings and so that the g menu switches to the lower portion of the screen seems to prevent the "ghosting" effect.

user6

2012-02-14 05:08

  ~0019502

Reminder sent to: Greendogo

What rendering mode are you using? Is TrueType enabled?

Greendogo

2012-02-14 13:54

reporter   ~0019552

TrueType was set to the default of 24.

user6

2012-02-14 14:45

  ~0019555

Reminder sent to: Greendogo

What PRINT_MODE are you using in init.txt?

Greendogo

2012-02-14 21:35

reporter   ~0019597

Last edited: 2012-02-14 21:53

PRINT_MODE is set to 2D

Edit: Here's a link to a picture of what is going on-
http://i43.photobucket.com/albums/e358/Greendogo/textghosting.jpg

user6

2012-02-16 07:29

  ~0019791

Reminder sent to: Greendogo

Does disabling TrueType fix the problem?

Greendogo

2012-02-16 13:58

reporter   ~0019843

Yes. Though, I wouldn't really say the problem is fixed if TrueType has to be turned off.

user6

2012-02-16 14:16

  ~0019844

Reminder sent to: Baughn

Another TrueType bug.

Greendogo

2012-02-18 21:26

reporter   ~0020088

Still happening in 0.34.02

Baughn

2012-02-22 16:11

manager   ~0020505

Pressing F10 fixes it for that screenful, right?

What's happening is that adventure-mode is occasionally optimized to not overwrite text that needs no overwriting, 2D-mode always updates only screen areas that have changed, and neither piece of code accounts for TTF text becoming horizontally smaller than tiles.

I suppose I'll have it also refresh the tiles that "should" have been overwritten.

Baughn

2012-02-23 15:02

manager   ~0020569

The actual bug was a bit more complicated.

Toady first draws eighty blank spaces to clear out the line, then draws the text on top of that. As an optimization, the TTF code only cares about the first tile of the text (it's "anchored" there), and when that's overwritten those eighty spaces never actually get drawn.

I changed the rendering to *always* draw spaces, which may then get overwritten by the actual text.

Issue History

Date Modified Username Field Change
2012-02-14 03:57 Greendogo New Issue
2012-02-14 04:15 Greendogo Note Added: 0019498
2012-02-14 04:19 Greendogo Note Edited: 0019498
2012-02-14 04:20 Greendogo Note Edited: 0019498
2012-02-14 05:08 user6 Note Added: 0019502
2012-02-14 13:54 Greendogo Note Added: 0019552
2012-02-14 14:45 user6 Note Added: 0019555
2012-02-14 17:06 user6 Tag Attached: AWAITING UPDATE
2012-02-14 21:35 Greendogo Note Added: 0019597
2012-02-14 21:53 Greendogo Note Edited: 0019597
2012-02-16 07:29 user6 Note Added: 0019791
2012-02-16 13:58 Greendogo Note Added: 0019843
2012-02-16 14:16 user6 Summary Old Menu Items Sticking In Adventure Mode Get/Ground Menu => Adv Mode "get" menu not refreshing properly with TrueType
2012-02-16 14:16 user6 Note Added: 0019844
2012-02-16 14:16 user6 Status new => assigned
2012-02-16 14:16 user6 Assigned To => Baughn
2012-02-17 06:10 user6 Tag Detached: AWAITING UPDATE
2012-02-18 21:26 Greendogo Note Added: 0020088
2012-02-22 16:11 Baughn Note Added: 0020505
2012-02-23 15:02 Baughn Note Added: 0020569
2012-02-23 15:02 Baughn Status assigned => resolved
2012-02-23 15:02 Baughn Fixed in Version => Next Version
2012-02-23 15:02 Baughn Resolution open => fixed