View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007032 | Dwarf Fortress | Dwarf Mode -- Jobs, Farming/Farmer's Workshop | public | 2014-07-10 23:59 | 2014-08-14 23:49 |
| Reporter | darkness100 | Assigned To | Toady One | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| OS | Windos 7 | ||||
| Product Version | 0.40.02 | ||||
| Fixed in Version | 0.40.09 | ||||
| Summary | 0007032: PROCESS_PLANT_TO_BAG reaction does not produce seeds | ||||
| Description | The reaction of processing plant to bag don't produce any rock nut. | ||||
| Tags | Intentional/Expected?, Probable Quick Fix, raw files | ||||
|
|
The new reaction PROCESS_PLANT_TO_BAG in reaction_other.txt does not have a seed as a product. In previous version this hard-coded reaction produced a seed. Should probably be matched with the brewing reactions to produce a seed. |
|
|
I think I solve the problem. The raw file of PROCESS_PLANT_TO_BAG should be added a line to produce a seed. And the raw file of quarry bush should be added a line to define the SEED_MAT of quarry bush. |
|
|
Additionally, the reaction produces 5 leaves regardless of how many bushes are used since the bag doesn't have [DOES_NOT_DETERMINE_PRODUCT_AMOUNT]. Adding that tag solves the problem. |
|
|
This is possibly related. It seems my pig tails did the same thing. I had some growing, actually it seemed a couple years, but suddenly now my seeds are gone. |
|
|
Yeah, I've had my cave wheat disappear once, and now my sweet pods and rock nuts are gone (even though I updated the raws). |
|
|
The solution to this one is simple enough:This exactly matches behavior for eating plants (start with 1 seed, 1/2 chance to increase to 2 seeds, and 1/8 chance to increase to 3 seeds IF it didn't choose 2), and should probably be used with the brewing reactions as well for consistency with older versions. |
|
|
Not sure seeds work the same now, though I can't say I paid much attention to it before, but even though the seed products for brewing are: [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT], it is 100% per plant in the stack...a stack of plant[4] is producing 4 seeds for me. |
|
|
It's been a long time since I've mucked around with the raws, so for readers in similar circumstances, here's a more detailed description of how I fixed my raws using HmH, Quietust, and darkness100's patches. 1. The files you need to change are in raw/objects. This will fix the issue for any new worlds generated after the change. To fix it in existing worlds, you need to get into data/save/regionx/raw/objects, where regionx is the name of your save. 2. Open reaction_other.txt and scroll down to "[REACTION:PROCESS_PLANT_TO_BAG]", the last reaction in the file. Inside the indented block opened with "[REAGENT:bag:1:BOX:NONE:NONE:NONE]", append the line "[DOES_NOT_DETERMINE_PRODUCT_AMOUNT]". At the end of the reaction, indented only one level, insert "[PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]" and, optionally, two copies of "[PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT]". 3. Open plant_standard.txt and scroll down to "[PLANT:BUSH_QUARRY]", the fifth plant in the file. Inside the first indented block, the one opened with "[USE_MATERIAL_TEMPLATE:STRUCTURAL:STRUCTURAL_PLANT_TEMPLATE]", append the line "[MATERIAL_REACTION_PRODUCT:SEED_MAT:LOCAL_PLANT_MAT:SEED]". |
|
|
I turned Kanddak's instructions into a diff: --- reaction_other.txt- 2014-08-02 03:38:33.318878918 -0400 +++ reaction_other.txt 2014-08-02 15:47:41.539514686 -0400 @@ -325,6 +325,10 @@ [EMPTY] [BAG] [PRESERVE_REAGENT] + [DOES_NOT_DETERMINE_PRODUCT_AMOUNT] [PRODUCT:100:5:GET_ITEM_DATA_FROM_REAGENT:plant:BAG_ITEM] [PRODUCT_TO_CONTAINER:bag] + [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT] + [PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT] + [PRODUCT:25:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT] [SKILL:PROCESSPLANTS] Those responsible for packaging .40.05 for Linux should consider applying this to their package. |
|
|
Your patch is missing the part for the plant_standard.txt file. --- ../../../x/df_linux/raw/objects/reaction_other.txt 2014-08-03 14:55:50.000000000 -0400 +++ reaction_other.txt 2014-08-03 18:43:37.903971931 -0400 @@ -325,6 +325,8 @@ [EMPTY] [BAG] [PRESERVE_REAGENT] + [DOES_NOT_DETERMINE_PRODUCT_AMOUNT] [PRODUCT:100:5:GET_ITEM_DATA_FROM_REAGENT:plant:BAG_ITEM] [PRODUCT_TO_CONTAINER:bag] + [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT] [SKILL:PROCESSPLANTS] --- ../../../x/df_linux/raw/objects/plant_standard.txt 2014-08-03 14:55:50.000000000 -0400 +++ plant_standard.txt 2014-08-03 18:44:44.640998605 -0400 @@ -210,6 +210,7 @@ [MATERIAL_VALUE:2] [EDIBLE_VERMIN] [ITEM_REACTION_PRODUCT:BAG_ITEM:PLANT_GROWTH:LEAVES:LOCAL_PLANT_MAT:LEAF] + [MATERIAL_REACTION_PRODUCT:SEED_MAT:LOCAL_PLANT_MAT:SEED] [BASIC_MAT:LOCAL_PLANT_MAT:STRUCTURAL] [PICKED_TILE:5][PICKED_COLOR:7:0:0] [GROWDUR:500][VALUE:2] |
|
|
@greycat: Noted. That explains why I'm still leaking rock nuts. I found that getting a working diff file from pasting in the text we posted is endlessly fussy due to DOS line endings and tab characters, so this time, I'm posting a link to a ready-made patch with all of the right formatting. http://s000.tinyupload.com/index.php?file_id=03211338005757724538 I have confirmed that this patch did work for me. Linux packagers: use this patch! |
|
|
Confirmed: The need to patch the raws before farming quarry bushes persists in 0.40.08. |
|
|
Please fix these entries into the raws before next update. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-07-10 23:59 | darkness100 | New Issue | |
| 2014-07-11 00:35 |
|
Note Added: 0025702 | |
| 2014-07-11 00:35 |
|
Assigned To | => user11 |
| 2014-07-11 00:35 |
|
Status | new => acknowledged |
| 2014-07-11 00:36 |
|
Summary | Do not produce rock nuts => PROCESS_PLANT_TO_BAG reaction does not produce seeds |
| 2014-07-11 00:36 |
|
Tag Attached: Intentional/Expected? | |
| 2014-07-11 01:12 | darkness100 | Note Added: 0025712 | |
| 2014-07-11 02:48 | HmH | Note Added: 0025722 | |
| 2014-07-11 17:34 |
|
Relationship added | has duplicate 0007094 |
| 2014-07-13 00:29 |
|
Relationship added | has duplicate 0007187 |
| 2014-07-13 00:53 | crossmr | Note Added: 0026096 | |
| 2014-07-15 03:43 | JoeJoe | Note Added: 0026448 | |
| 2014-07-15 18:05 |
|
Relationship added | related to 0007337 |
| 2014-07-15 19:49 |
|
Relationship deleted | related to 0007337 |
| 2014-07-25 05:54 | Quietust | Note Added: 0027485 | |
| 2014-07-25 05:54 | Quietust | Note Edited: 0027485 | |
| 2014-07-25 05:55 | Quietust | Note Edited: 0027485 | |
| 2014-07-25 06:44 |
|
Tag Attached: Probable Quick Fix | |
| 2014-07-27 15:19 |
|
Note Added: 0027723 | |
| 2014-07-30 12:12 | Kanddak | Note Added: 0027973 | |
| 2014-07-30 12:13 | Kanddak | Note Edited: 0027973 | |
| 2014-07-30 12:59 |
|
Status | acknowledged => confirmed |
| 2014-08-02 12:59 | toombs | Note Added: 0028158 | |
| 2014-08-03 15:47 | greycat | Note Added: 0028241 | |
| 2014-08-05 10:21 | toombs | Note Added: 0028385 | |
| 2014-08-05 10:45 | toombs | Note Edited: 0028385 | |
| 2014-08-05 11:27 | toombs | Note Edited: 0028385 | |
| 2014-08-05 13:50 | toombs | Note Edited: 0028385 | |
| 2014-08-11 11:57 | Kanddak | Note Added: 0028821 | |
| 2014-08-11 11:57 | Kanddak | Tag Attached: raw files | |
| 2014-08-12 18:52 | MrC | Note Added: 0028909 | |
| 2014-08-13 12:07 | Toady One | Status | confirmed => resolved |
| 2014-08-13 12:07 | Toady One | Fixed in Version | => Next Version |
| 2014-08-13 12:07 | Toady One | Resolution | open => fixed |
| 2014-08-13 12:07 | Toady One | Assigned To | user11 => Toady One |
| 2015-11-06 05:47 |
|
Relationship added | related to 0009110 |
| 2015-11-06 18:15 | lethosor | Relationship replaced | has duplicate 0009110 |
