View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011189 | Dwarf Fortress | Title Screen | public | 2019-12-10 14:35 | 2019-12-11 13:35 |
| Reporter | LordBobSaget | Assigned To | Loci | ||
| Priority | immediate | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | duplicate | ||
| Product Version | 0.44.12 | ||||
| Summary | 0011189: Choosing to start a game on a save file that has been deleted begins an accumulation of an endless amount of memory | ||||
| Description | My PC has 16GB of RAM and dwarf fortress was using 95 percent of it before I managed to kill the process. It was showing no signs of stopping and likely would have crashed my computer if I hadn't. | ||||
| Steps To Reproduce | 1. Create a new world. 2. Go to the title screen. 3. Minimize the game and navigate to your dwarf fortress saves folder on your computer. 4. Delete the save of the world you just created. 5. Return to the game window and select "Start Playing" for the world you both just created and deleted. 6. Choose one of the three options, Dwarf Fortress, Adventurer, or Legends. 7. Try to kill the process before it bluescreens your OS. | ||||
| Additional Information | I was using the masterwork modpack and haven't tried reproducing it on the normal game, but I'm almost certain it wouldn't make a difference. | ||||
| Tags | No tags attached. | ||||
|
|
Nicely handling an intentionally-sabotaged directory structure isn't really a priority. (0010782) |
|
|
Note that this is a duplicate of 0005668, but I think the way DF handles this situation is a bug. I have gotten DF to crash by doing this before, so I suspect that the code that's trying to read the file ends up reading random values, and allocating varying amounts of memory based on that. If DF tries to allocate too much memory, a typical OS would kill it (although if it's allocating memory slowly enough, it may cause your OS to become unresponsive for a while). At any rate, the advice of "don't mess with save files when DF is running" from 0005668 is good, so this probably won't be a high-priority fix when the next bug-fixing phase starts, but it's still a bug as far as I'm concerned. Edit: Loci beat me to it. If you were modifying files that DF was actively using, I would agree; however, since this is entirely possible to trigger accidentally (deleting a save that you're not using, then accidentally selecting it from the "start playing" menu later), I think it's worth addressing. <del>Edit 2: From testing on macOS, DF just seems to lock up without eating up memory. However, the list under "start playing" updates whenever the title screen is recreated, which happens when saving a game (or generating a world) and exiting to the title screen. I no longer think this is easy to reproduce accidentally, so I agree with Loci on this.</del> Update: On second thought, I've decided to reopen the parent of this issue: 0010782:0040703 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-12-10 14:35 | LordBobSaget | New Issue | |
| 2019-12-11 13:31 | Loci | Note Added: 0039610 | |
| 2019-12-11 13:31 | Loci | Relationship added | duplicate of 0010782 |
| 2019-12-11 13:31 | Loci | Status | new => resolved |
| 2019-12-11 13:31 | Loci | Resolution | open => duplicate |
| 2019-12-11 13:31 | Loci | Assigned To | => Loci |
| 2019-12-11 13:34 | lethosor | Note Added: 0039612 | |
| 2019-12-11 13:35 | lethosor | Relationship added | duplicate of 0005668 |
| 2019-12-11 13:38 | lethosor | Note Edited: 0039612 | |
| 2019-12-11 13:42 | lethosor | Note Edited: 0039612 | |
| 2020-08-22 17:08 | lethosor | Note Edited: 0039612 | |
| 2020-08-22 17:09 | lethosor | Note Edited: 0039612 |
