View Issue Details

IDProjectCategoryView StatusLast Update
0001235Dwarf FortressTechnical -- Generalpublic2014-01-27 13:04
ReporterRhenaya Assigned To 
PrioritynoneSeveritytweakReproducibilityN/A
Status newResolutionopen 
PlatformNotebookOSWindowsOS VersionVista
Product Version0.31.03 
Summary0001235: No errorlog when custom reaction specifies invalid building
DescriptionIt seems that custom Reactions can only use the Kiln, Kitchen and Smelter from the existing Buidlings (soap maker as it is, is already a custom building).

This also shows up in the string dump as reaction related stuff on the wiki only show the strings for that 3 buildings too. tested around for most buildings and it doesnt work with other buildings at all (it doesnt even give an error into the log file).
Additional InformationI know its not really a bug and just annoying, but its more than just a suggestion :p
Tagscustom buildings, Intentional/Expected?, modding, reactions

Activities

user6

2010-04-16 09:06

  ~0003856

The only other building they're supposed to work for is the Tanner's Shop. As long as that works, this is all expected behavior, except that it probably should output an error into the errorlog, yeah.

Rhenaya

2010-04-16 10:56

reporter   ~0003871

well if i want to use a reaction on another workshop? dont really think thats intended that you are unable to make reactions for carpentry or farmers workshop and the like. so you always need a new building if its not fitting to the building that are allowed now.

user6

2010-04-16 11:34

  ~0003878

Last edited: 2010-04-16 11:35

Yes, it's intended. See this quote from Toady: http://www.bay12games.com/forum/index.php?topic=30026.msg994813#msg994813
In the dev log, I was just talking about the limited number of building types (kitchen, tanner, kiln, smelter, custom).

Referring to this devlog entry: http://www.bay12games.com/dwarves/dev_2009.html#2009-12-08
Modders can also set any of their custom jobs to be automated for whatever building they put them in (among the limited options) and their custom buildings.

See also this quote: http://www.bay12games.com/forum/index.php?topic=21498.msg338302;topicseen#msg338302
"Actually, he listed three jobs. That take place in three different workshops.

This implies (at least, without too much wishful thinking) that the reaction raws have been generalized to accept any workshop."

Nope -- the three workshops are some of those with the easiest jobs/interfaces currently. Updating something like the crafts or forge shop would take more effort, and for those item crafting shops, there are also additional issues, such as their future form after some of the req/bloats come in. It's a much larger project, and something I don't have time for for this release.


Rhenaya

2010-04-16 12:51

reporter   ~0003888

well, still its kinda an annoying bug for me :/ but then we should either close it or let toady decide if its an actuall bug or suggestion

Add Note

Note

Issue History

Date Modified Username Field Change
2010-04-16 08:24 Rhenaya New Issue
2010-04-16 09:04 Kennel Tag Attached: custom buildings
2010-04-16 09:04 Kennel Tag Attached: modding
2010-04-16 09:04 Kennel Tag Attached: reactions
2010-04-16 09:06 user6 Note Added: 0003856
2010-04-16 09:07 user6 Summary Custom Reactions cant use existing Buildings => No errorlog for reactions with invalid buildings
2010-04-16 09:07 user6 Summary No errorlog for reactions with invalid buildings => No errorlog for custom reactions with invalid buildings
2010-04-16 10:56 Rhenaya Note Added: 0003871
2010-04-16 11:34 user6 Note Added: 0003878
2010-04-16 11:35 user6 Note Edited: 0003878
2010-04-16 12:51 Rhenaya Note Added: 0003888
2010-04-16 14:44 user6 Summary No errorlog for custom reactions with invalid buildings => No errorlog when custom reaction specifies invalid building
2010-06-29 07:38 user6 Category Technical => Technical -- General
2014-01-27 13:04 user6 Tag Attached: Intentional/Expected?