View Issue Details

IDProjectCategoryView StatusLast Update
0012852Dwarf FortressAdventure Mode -- Character Creationpublic2025-05-19 18:20
ReporterAussiemon Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformWindowsOSWindows 10 
Product Version51.01-beta 
Summary0012852: Necromancers ignore NO_PHYS_ATT_GAIN and can raise physical attributes
DescriptionNecromancers are still able to train physical stats like STRENGTH and AGILITY, despite having the NO_PHYS_ATT_GAIN trait.

Verified in 51.01-beta with DFHack.
Steps To Reproduce1. Note physical attributes values.
2. Learn the secrets of life and death.
3. Train physical attributes.
4. Note that physical attribute values have increased.
Additional InformationWith DFHack I was able to verify that 1) my necromancer does have the NO_PHYS_ATT_GAIN trait, and 2) my necromancer is still gaining physical attribute values.

This matches reported behavior in the wiki as of version 0.47.05: https://dwarffortresswiki.org/index.php/Necromancer#Playing_as_a_necromancer
Tagsadventurer mode, necromancer

Activities

Quietust

2025-05-18 19:54

reporter   ~0042713

Last edited: 2025-05-19 18:19

The logic which checks for NO_PHYS_ATT_GAIN in syndromes while boosting physical attributes appears to be backwards:

* If the unit is under the effect of CE_REMOVE_TAG:NO_PHYS_ATT_GAIN, it bails out
* If the unit is under the effect of CE_ADD_TAG:NO_PHYS_ATT_GAIN, it proceeds to add the attribute

The check for the NO_PHYS_ATT_GAIN caste flag appears to work correctly.

This appears to have been broken ever since version 0.34.

Quietust

2025-05-18 20:11

reporter   ~0042714

Last edited: 2025-05-19 18:20

The checks inside the physical attribute rusting logic for NO_PHYS_ATT_RUST also appear to be reversed in the same way.

Add Note

Note

Issue History

Date Modified Username Field Change
2024-04-29 23:44 Aussiemon New Issue
2024-05-04 21:29 Aussiemon Tag Attached: adventurer mode
2024-05-04 21:29 Aussiemon Tag Attached: necromancer
2024-08-22 22:17 lethosor Product Version 50.11 => 51.01-beta
2025-05-18 19:54 Quietust Note Added: 0042713
2025-05-18 19:59 Quietust Note Edited: 0042713
2025-05-18 20:11 Quietust Note Added: 0042714
2025-05-19 18:19 Quietust Note Edited: 0042713
2025-05-19 18:20 Quietust Note Edited: 0042714