View Issue Details

IDProjectCategoryView StatusLast Update
0001789Dwarf FortressDwarf Mode -- Moodspublic2016-07-04 16:23
ReporterImmoralFibre Assigned Tolethosor  
PrioritynormalSeveritytextReproducibilityhave not tried
Status confirmedResolutionopen 
Platformx86_64OSWindows XP x64 
Product Version0.31.03 
Summary0001789: Noble profession change announcements always list nobles' current profession
DescriptionMy bookkeeper was also a competent carpenter. He had a fey mood and ascended to legendary carpenter. However, after the item creation message, I get the following:

"Lorbam Idosonul has become a bookkeeper."

I'm guessing that behind the scenes, the code is setting the new skill level, then using the dwarf's title in the message, assuming it'll reflect the new top skill. Or something like that.

I would've expected the message to reflect the newly attained skill level, i.e. "Legendary Carpenter".
Steps To Reproduce1. Assign some nobles.
2. Wait for one of them to have a skill-granting mood.
3. Satisfy the mood successfully.
4. Observe messages: "Urist McNoble, <noble> has created..." followed by "Urist McNoble has become a <noble>".

From 0004235:
1. Embark with a dwarf that has the most social skills and novice in all medical skills.
2. Give him the miner job with a pick.
3. Have him mine soil for a little bit.
4. Once his mining skill exceeds his medical skills the message will pop up.

From 0007708
1. Start with all dwarves completely unskilled.
2. Get the expedition leader to do stuff until they reach novice in something that warrants a title change.
Additional InformationSaves:
http://dffd.bay12games.com/file.php?id=12220 (0.43.04)
Tags0.43.04

Relationships

has duplicate 0001891 resolveduser6 Getting profession updates, but not changing titles 
has duplicate 0002251 resolvedLogical2u Chief Medical dwarf is assigned the post Chief Medical dwarf 
has duplicate 0002349 resolveduser6 So & So has become a ______ 
has duplicate 0004235 resolvedlethosor Expedition leader X has become expedition leader 
has duplicate 0009885 resolvedlethosor Dwarf keeps becoming broker even though they were already a broker 
has duplicate 0007708 resolveduser1294 Expedition leader "has become a expedition leader" 
related to 0001482 resolvedToady One Children that gain professional skills still grow up to be Peasants 
related to 0006357 new Adventurer title stops updating after the first "Legendary" weapon skill 

Activities

GRead

2010-05-06 17:51

reporter   ~0006319

This is actually even simpler to reproduce; just create a military. Now start assigning and canceling kill orders while the militia commander is off duty. Note how the announcement reads: "soandso has become a militia commander" when s/he goes on duty, and then "soandso has become a militia commander" when s/he goes off duty.

user6

2010-05-06 18:34

  ~0006325

GRead: that's an old bug.

# 001029 □ [dwarf mode][interface][announcements] (http://www.bay12forums.com/smf/index.php?topic=25110.0) when entity appointee and related positions "X" change their base profession, it says "X has become an X"

I'm not sure it's exactly the same as the one in this report, but it's definitely related.

Afghani84

2015-03-07 12:17

reporter   ~0032340

I can confirm that this is still an issue in 40.23

lethosor

2016-07-04 16:20

manager   ~0035559

Merged in 0004235 and friends.

Add Note

Note

Issue History

Date Modified Username Field Change
2010-05-06 17:28 ImmoralFibre New Issue
2010-05-06 17:51 GRead Note Added: 0006319
2010-05-06 18:34 user6 Note Added: 0006325
2010-05-16 00:27 user6 Relationship added parent of 0001891
2010-06-10 04:55 Logical2u Relationship added has duplicate 0002251
2010-06-15 19:16 user6 Relationship added has duplicate 0002349
2011-03-15 19:19 user6 Relationship added parent of 0004235
2013-09-22 17:50 user6 Relationship added related to 0001482
2013-09-22 17:50 user6 Relationship added related to 0006357
2014-01-27 14:39 user6 Relationship replaced has duplicate 0001891
2014-08-05 05:47 lethosor Assigned To => lethosor
2014-08-05 05:47 lethosor Status new => acknowledged
2015-03-07 12:17 Afghani84 Note Added: 0032340
2016-07-04 16:17 lethosor Summary Mood -> legendary carpenter, but reported as "has become a bookkeeper" => Noble profession change announcements always list nobles' current profession
2016-07-04 16:19 lethosor Steps to Reproduce Updated
2016-07-04 16:20 lethosor Relationship replaced has duplicate 0004235
2016-07-04 16:20 lethosor Status acknowledged => confirmed
2016-07-04 16:20 lethosor Note Added: 0035559
2016-07-04 16:21 lethosor Relationship added has duplicate 0009885
2016-07-04 16:21 lethosor Relationship added has duplicate 0007708
2016-07-04 16:22 lethosor Steps to Reproduce Updated
2016-07-04 16:22 lethosor Additional Information Updated
2016-07-04 16:23 lethosor Tag Attached: 0.43.04