View Issue Details

IDProjectCategoryView StatusLast Update
0004408Dwarf FortressReactionspublic2016-05-13 00:06
Reporteruser1294Assigned ToToady One  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.31.25 
Fixed in Version0.43.03 
Summary0004408: Decoration reactions never result in quality decorations
DescriptionReactions that add an improvement to an object, like the one I posted at 0004378, never result in quality decorations. I've tested this in adventure mode via a knapping reactions and a knapping demigod, and in Dwarf mode via a stonecraft reaction, in both cases adding stone spikes to an object of any kind.
Steps To ReproduceAdd a reaction with the IMPROVEMENT tag as per the linked issue that you can easily repeat, and repeat using it.
TagsNo tags attached.

Relationships

related to 0004378 resolvedToady One Decorating with adventure mode reactions results in "You ... make nothing of note" 
related to 0004221 resolvedToady One Adventure mode reactions no longer create quality items 
related to 0004409 resolvedToady One Creating masterwork in adventure mode results in history line "created a masterful item for at an unknown site (or wrong site)" 
related to 0004577 resolvedToady One Rust on Glazer skill isn't removed with practice, skill can't increase past Proficient 

Activities

NW_Kohaku

2012-03-19 14:15

reporter   ~0021606

This problem appears to be because of IMPROVEMENT not respecting SKILL in any way, as per 0004577, and IMPROVEMENT also does not respect the number of reagents reserved for the IMPROVEMENT. (You only improve one item with the IMPROVEMENT token, regardless of number of reagents. Multiple IMPROVEMENTs only improve the same item multiple times.)

A savefile with a modded reaction that shows these problems with a legendary crafter making and improving items - http://dffd.wimbli.com/file.php?id=5932

Issue History

Date Modified Username Field Change
2011-03-31 10:35 user1294 New Issue
2011-03-31 11:04 user6 Relationship added related to 0004378
2011-03-31 11:05 user6 Relationship added related to 0004221
2011-03-31 12:26 user6 Relationship added related to 0004409
2012-03-19 07:10 user6 Relationship added related to 0004577
2012-03-19 14:15 NW_Kohaku Note Added: 0021606
2016-05-13 00:06 Toady One Status new => resolved
2016-05-13 00:06 Toady One Fixed in Version => Next Version
2016-05-13 00:06 Toady One Resolution open => fixed
2016-05-13 00:06 Toady One Assigned To => Toady One