View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0005021Dwarf FortressDwarf Mode -- Tradepublic2012-01-12 20:472016-05-06 16:24
ReporterGreymane Assigned ToToady One  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.31.25 
Fixed in Version0.43.01 
Summary0005021: "Masterwork has been lost" when merchants leave with traded items
DescriptionAs soon as visiting merchants leave the map, masterwork items traded to merchants are reported as stolen ('A masterwork of [dwarf] has been lost!') with accompanying negative thoughts for the creator. Have so far tested it on crafts of all kinds (mugs included), nest boxes, weapons, ammo, bins, and barrels.
Steps To ReproduceTrade a masterwork quality item to any merchant and wait for them to leave the map with the item.
Additional InformationSaves:
http://dffd.bay12games.com/file.php?id=11784 (0.42.06)
http://dffd.bay12games.com/file.php?id=11787 (0.42.06)
http://dffd.bay12games.com/file.php?id=11859 (0.42.06)
Tags0.42.06

Relationships

has duplicate 0009576 resolvedlethosor Sold master quality items reported as "lost masterworks" upon merchants leaving the map 
has duplicate 0009691 resolveduser1294 Masterworks lost through trade 
related to 0003169 feedbackuser6 Bone carvers suffer art defacement when somebody leaves the map with stuck-in masterpiece bolts 
related to 0005441 new Modded Civ with Flee/Hide Interaction triggers Ambush pause with diplomat 
related to 0005442 new Traders leaving map with their own caged Animal triggers snatcher pause 
related to 0009780 resolvedToady One Traded masterwork meals result in "Masterwork has been lost" message 

Activities

Kogut

2012-01-13 05:06

reporter   ~0019372

Please, upload savegame (it never happened in my game)

Quietust

2012-01-13 06:02

reporter   ~0019374

By any chance are you trading with a (modded) Kobold civilization?

user11

2012-01-13 09:14

  ~0019378

Reminder sent to: Greymane

Can you update this report with a save (zip you DF/data/save/region folder and upload it to http://dffd.wimbli.com and post a link in the bug report) and let us know if you are using any mods (such as a modded kobold civ, etc).

Greymane

2012-01-13 14:31

reporter   ~0019386

Last edited: 2012-01-13 15:57

 http://dffd.wimbli.com/file.php?id=5360

Save is up. I AM using mods, nameless homebrew stuff that does include a couple alterations to the Kobold civilization.

Oddly, while I had seen this happen in completely clean, unmodded worlds before I started modding, I actually can't seem to get it to repeat in a clean game anymore. Might have jumped the gun on a bug report, if it's the fault of the mods.

EDIT: Just to specifically address the question Quietust asked (which I had misread at first), the trading in question is not with Kobolds, who are not modded for trade (just a few equipment and job related things). Trade is still only with dwarves, elves, and humans and the bug crops up with all of them.

Kogut

2012-01-16 04:25

reporter   ~0019396

Are you playing as kobold civ?

Greymane

2012-01-16 15:44

reporter   ~0019398

Kogut: Belatedly, nope. Just dwarves. In most of the worlds/forts it happened in, there weren't even any kobolds because they'd all died out. Whatever was causing it wasn't kobold-related.

ptb_ptb

2014-12-31 05:05

reporter   ~0031611

I haven't seen this in DF 0.40.~~ Maybe it can be closed?

user6

2014-12-31 07:54

  ~0031615

Anyone able to reproduce this with or without mods?

vomov

2015-01-01 01:57

reporter   ~0031626

I can't seem to reproduce this, because I can't trade masterwork stuff (not even through messing around with bins), which I think is intended behaviour (maybe for now, but still intended). I've not seen this issue for quite some time, so I suspect it can be closed.

ptb_ptb

2015-01-01 02:44

reporter   ~0031628

@vomov Not being able to trade Artifacts is as intended. Not being able to trade Masterwork (would be) a bug.

user8971

2015-01-02 10:45

  ~0031640

No, Footkerchief. I am selling masterful ☼trap component☼s to dwarves and humans in 40.23 and neither such message nor bad thoughts of my carpenters noted.

vomov

2015-01-05 03:43

reporter   ~0031698

@ptb_ptb: mixed the terms 'Masterwork' and 'Artefact', whoops! (the negative thought threw me off)

Selling or getting rid of Masterwork stuff isn't a problem, as far as I can see; I've been deforesting aggressively and selling masterwork stuff for quite some time now, without issues.

Artefacts being non-tradable and the bad thoughts etc. resulting from a loss seems to be working as intended.

user8971

2015-01-05 09:02

  ~0031700

So, can this be closed as "no more in current version"/"maybe caused by a mod" or something like that, at least until somebody manages to reproduce it in 0.40.20 or higher version?

user6

2015-01-05 17:00

  ~0031720

That seems reasonable.

If anyone has a save that reproduces this problem in the latest version, please upload it to http://dffd.wimbli.com/ and PM a manager on the forums (or reopen the report).

lethosor

2016-03-16 14:29

manager   ~0034860

Reopened per 0009576 and http://www.bay12forums.com/smf/index.php?topic=52185.msg6876977#msg6876977

Save from VitalArt on the forums: http://dffd.bay12games.com/file.php?id=11859

Saves from 0009576:
http://dffd.bay12games.com/file.php?id=11784
http://dffd.bay12games.com/file.php?id=11787

SpoCk0nd0pe

2016-03-18 14:05

reporter   ~0034872

I just wanted to report it happened in my fort too. Do you still need another save?

seeschloss

2016-03-19 08:40

reporter   ~0034874

Just in case it can be useful, here's a save where this happened to me:

http://dffd.bay12games.com/file.php?id=11871

On a completely unmoded game.

DaliTimelord

2016-04-02 17:28

reporter   ~0034965

Also happened to me after the merchants left the map.

http://dffd.bay12games.com/file.php?id=11911

Unmodded, now with fancy screenshots!

Aussiemon

2016-04-07 23:52

reporter   ~0034984

In case it might assist further, here is another save, taken just before the traders leave the map with the "lost" masterwork.

http://dffd.bay12games.com/file.php?id=11922

Issue History

Date Modified Username Field Change
2012-01-12 20:47 Greymane New Issue
2012-01-12 22:22 user6 Relationship added related to 0003169
2012-01-13 05:06 Kogut Note Added: 0019372
2012-01-13 06:02 Quietust Note Added: 0019374
2012-01-13 07:01 user6 Tag Attached: AWAITING UPDATE
2012-01-13 09:14 user11 Note Added: 0019378
2012-01-13 14:31 Greymane Note Added: 0019386
2012-01-13 14:42 Greymane Tag Attached: UPDATE GIVEN
2012-01-13 15:57 Greymane Note Edited: 0019386
2012-01-13 16:27 user6 Tag Detached: AWAITING UPDATE
2012-01-13 16:27 user6 Tag Detached: UPDATE GIVEN
2012-01-13 16:27 user6 Summary Traded Masterworks Count As Stolen => "Masterwork has been lost" when merchants leave with traded items
2012-01-16 04:25 Kogut Note Added: 0019396
2012-01-16 15:44 Greymane Note Added: 0019398
2012-02-25 12:45 user6 Relationship added related to 0005441
2012-02-25 12:46 user6 Relationship added related to 0005442
2014-12-31 05:05 ptb_ptb Note Added: 0031611
2014-12-31 07:54 user6 Note Added: 0031615
2014-12-31 07:54 user6 Assigned To => user6
2014-12-31 07:54 user6 Status new => feedback
2015-01-01 01:57 vomov Note Added: 0031626
2015-01-01 02:44 ptb_ptb Note Added: 0031628
2015-01-02 10:45 user8971 Note Added: 0031640
2015-01-05 03:43 vomov Note Added: 0031698
2015-01-05 09:02 user8971 Note Added: 0031700
2015-01-05 17:00 user6 Note Added: 0031720
2015-01-05 17:00 user6 Status feedback => resolved
2015-01-05 17:00 user6 Resolution open => unable to reproduce
2016-03-16 14:28 lethosor Relationship added has duplicate 0009576
2016-03-16 14:29 lethosor Note Added: 0034860
2016-03-16 14:29 lethosor Status resolved => feedback
2016-03-16 14:29 lethosor Resolution unable to reproduce => reopened
2016-03-16 14:31 lethosor Additional Information Updated
2016-03-18 14:05 SpoCk0nd0pe Note Added: 0034872
2016-03-18 19:20 Sarmatian123 Tag Attached: 0.42.06
2016-03-19 08:40 seeschloss Note Added: 0034874
2016-04-02 17:28 DaliTimelord Note Added: 0034965
2016-04-07 23:52 Aussiemon Note Added: 0034984
2016-04-15 02:16 user1294 Status feedback => confirmed
2016-04-15 02:17 user1294 Relationship added has duplicate 0009691
2016-05-06 16:24 Toady One Status confirmed => resolved
2016-05-06 16:24 Toady One Fixed in Version => Next Version
2016-05-06 16:24 Toady One Resolution reopened => fixed
2016-05-06 16:24 Toady One Assigned To user6 => Toady One
2016-05-29 19:36 user11 Relationship added related to 0009780