View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005854 | Dwarf Fortress | Dwarf Mode -- Diplomacy | public | 2012-04-30 19:13 | 2015-12-02 13:42 |
| Reporter | Quietust | Assigned To | Toady One | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | 0.34.07 | ||||
| Fixed in Version | 0.40.05 | ||||
| Summary | 0005854: Diplomats don't bring bodyguards | ||||
| Description | Back in the old 2D versions of Dwarf Fortress, Human diplomats were escorted by a pair of swordsmen, and this behavior was linked to their [PLAINS_SETTLEMENTS] raw token. In version 0.27.173.38a, this behavior was split off to the [DIPLOMAT_BODYGUARDS] token, but at least since 0.28.181.40d it hasn't actually done anything - Human diplomats always arrived alone and unprotected. In an effort to track down this problem, I located the code for diplomat arrival in 0.34.07 and the check against [DIPLOMAT_BODYGUARDS], and I've determined why it's not working: the game builds a list of valid military professions and then checks whether or not that list is empty before proceeding to create the bodyguards, but the condition is backwards, so it only proceeds if the list is empty (rather than non-empty). The following binary patch fixes this bug in Win32 v0.34.07 SDL: 00476328 : 85 -> 84 | ||||
| Tags | binary patch | ||||
|
|
Interestingly, when the diplomat bodyguards do arrive, they show up as "Merchant" in the Units screen if a caravan is present and "Friendly" if no caravan is present, exactly the same as with caravan guards. |
|
|
Updated patch for Win32 v0.34.11 SDL: 0493E28 : 85 -> 84 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-04-30 19:13 | Quietust | New Issue | |
| 2012-04-30 19:13 | Quietust | Tag Attached: binary patch | |
| 2012-04-30 20:49 | Quietust | Note Added: 0022408 | |
| 2012-05-22 15:03 |
|
Relationship added | related to 0005098 |
| 2012-05-22 21:14 | Quietust | Note Edited: 0022408 | |
| 2012-06-07 06:15 | Quietust | Note Added: 0022890 | |
| 2012-06-12 13:34 | Quietust | Note Edited: 0022408 | |
| 2014-03-25 13:13 |
|
Assigned To | => user11 |
| 2014-03-25 13:13 |
|
Status | new => acknowledged |
| 2014-07-23 10:21 | Toady One | Status | acknowledged => resolved |
| 2014-07-23 10:21 | Toady One | Fixed in Version | => Next Version |
| 2014-07-23 10:21 | Toady One | Resolution | open => fixed |
| 2014-07-23 10:21 | Toady One | Assigned To | user11 => Toady One |
