View Issue Details

IDProjectCategoryView StatusLast Update
0005948Dwarf FortressDwarf Mode -- Jobs, Haulingpublic2012-05-27 18:24
Reporterag Assigned ToToady One  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.34.10 
Fixed in Version0.34.11 
Summary0005948: Detaching container from a Store In Bin/Barrel job causes crash in combining code.
DescriptionWhen the target container used in a new-style batch Store In Bin/Barrel job is removed, it causes a crash in the code used to detect if an item can be combined into an already existing job.
Steps To ReproduceEnsure there are many pending items to store that suddenly get the opportunity; wait until a suitable combined job is in progress, and forbid the container. As soon as the code tries to stockpile another item, it will crash.
Additional InformationWhen the container is forbidden, it is immediately removed from the job; but the job itself only gets a flag set, and would be cancelled at a later point. Meanwhile, the loop that searches for a suitable job to combine into does not check this flag, and assumes there always is a container item attached. When it fails to find an item reference of type 2, it crashes trying to access a NULL pointer.

This explains the crash mentioned in bug 0005937.
TagsNo tags attached.

Relationships

related to 0005937 resolvedToady One Hauler with bin wanders in circles 

Activities

user6

2012-05-24 12:00

  ~0022705

Unless I'm misunderstanding something, this is a duplicate of 0005937. If you find information that explains an existing report, it's more helpful to post that information at the existing report than to create a new report.

Issue History

Date Modified Username Field Change
2012-05-24 11:30 ag New Issue
2012-05-24 12:00 user6 Note Added: 0022705
2012-05-24 12:00 user6 Relationship added duplicate of 0005937
2012-05-24 12:00 user6 Status new => resolved
2012-05-24 12:00 user6 Resolution open => duplicate
2012-05-24 12:00 user6 Assigned To => user6
2012-05-24 14:47 user6 Assigned To user6 =>
2012-05-24 14:47 user6 Status resolved => new
2012-05-24 15:11 user6 Relationship replaced related to 0005937
2012-05-27 18:19 Toady One Status new => resolved
2012-05-27 18:19 Toady One Fixed in Version => Next Version
2012-05-27 18:19 Toady One Assigned To => Toady One
2012-05-27 18:24 Toady One Status resolved => assigned
2012-05-27 18:24 Toady One Status assigned => resolved
2012-05-27 18:24 Toady One Resolution duplicate => fixed