View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006475 | Dwarf Fortress | Dwarf Mode -- Idle Behavior | public | 2014-04-29 14:57 | 2014-07-12 19:56 |
| Reporter | Quietust | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | won't fix | ||
| Product Version | 0.34.11 | ||||
| Summary | 0006475: Old acquaintances forgotten based on wrong criteria | ||||
| Description | When a dwarf has not talked to an acquaintance for over a year, the acquaintance appears to be forgotten unless one of two conditions are true: 1. the dwarf itself has the unit flags "move_state", "dead", or "has_mood" set. 2. the acquaintance strength (number of talks) is greater than or equal to 30 (the threshold for "long-time acquaintance") The first condition is almost definitely wrong - logically, it should be checking the flags on the acquaintance record itself, which would correspond to the flags for Friend, Grudge, and Bonded Animal (to prevent those from being forgotten). | ||||
| Additional Information | This bug appears to date back to version 0.28.181.40d, where it looks like it was trying to check the Friend and Grudge flags but looking in the wrong place. | ||||
| Tags | binary patch | ||||
|
|
The following binary patches should fix this bug in version 0.34.11: 0.34.11 Win32 SDL: 0x47BA2B : F6 81 E0 00 00 00 07 -> F7 40 0C 07 00 00 00 0.34.11 Linux: 0x7F56AD : A9 8C -> AA 0C 0.34.11 OSX: 0x7D9C0C : 88 8C -> 8A 0C The bug itself was discovered in the process of comparing the implementation of friendship between versions 0.23 and 0.34. |
|
|
This may well no longer be an issue, since the old Friend system appears to have been scrapped entirely and replaced with something else that's stored at the hist_figure level. |
|
|
I'll go ahead an resolve it since it seems the system was rewritten. If you find that not to be the case, just PM a manager on the forums to reopen it. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-04-29 14:57 | Quietust | New Issue | |
| 2014-04-29 18:25 | Quietust | Note Added: 0024739 | |
| 2014-04-29 18:26 | Quietust | Tag Attached: binary patch | |
| 2014-04-29 18:33 | Quietust | Note Edited: 0024739 | |
| 2014-04-30 00:15 |
|
Assigned To | => user11 |
| 2014-04-30 00:15 |
|
Status | new => acknowledged |
| 2014-04-30 09:47 | Quietust | Note Edited: 0024739 | |
| 2014-07-12 19:50 | Quietust | Note Added: 0026067 | |
| 2014-07-12 19:56 |
|
Note Added: 0026068 | |
| 2014-07-12 19:56 |
|
Status | acknowledged => resolved |
| 2014-07-12 19:56 |
|
Resolution | open => won't fix |
