0011164: NPCs at reclaimed site don't know who they are

ID	Project	Category	View Status	Date Submitted	Last Update

0011164	Dwarf Fortress	Adventure Mode -- Sites	public	2019-10-21 20:57	2019-10-26 07:37

Reporter	Shonai_Dweller	Assigned To
Priority	normal	Severity	minor	Reproducibility	always
Status	new	Resolution	open
OS	Windows	OS Version	10
Product Version	0.44.12

Summary	0011164: NPCs at reclaimed site don't know who they are
Description	Here some odd behavior in Adventurer. In the save below, my adventurer started in this site, a cave recently reclaimed (during initial worldgen) by my civ. If you ask any of the NPCs around about their professions, they all say "I am a peasant" even though they are farmers, woodcutters, doctors, etc. If you ask them about the surrounding area they reply "ask me when I've returned home". So it seems that NPCs at reclaimed sites aren't being properly connected to those sites.
Steps To Reproduce	Open save, talk to nearest dorf. Save: http://dffd.bay12games.com/file.php?id=14573
Additional Information	May be unrelated, but this save also demonstrates the adventurer retire-unretire crash bug 0010364
Tags	No tags attached.

Shonai_Dweller 2019-10-24 19:30 reporter ~0039555	Tried a similar starting spot (reclaimed cave) in a new world (same raw tweaks) and this time npcs are all acting fine. They know who and where they are. The new world I tried doesn't crash on retire-unretire either, so whatever was going on with the npcs previously might be a related side effect of the save corruption which caused the crash.

Shonai_Dweller 2019-10-24 22:04 reporter ~0039556	And in the same world mentioned in my last comment, I tried a new adventurer in a different cave (I think this one was reclaimed while I was playing, rather than a product of initial worldgen). This time, all the NPCs were confused again. Non-military dwarves all say "I am a peasant" and everyone says "Ask me when I've returned to my home". In addition, on retire, my Adventurer is not listed in Legends. This also happens in the save above (mentioned in my comment on Adventurer crash bug 0010364) However, unlike the initial reported save, unretire actually works without crashing. The only difference between this and my other reported confused NPC/Adventurer crash is that I'm not using save compression this time. Also possibly relevant, the working cave embark was a proper ex-kobold site, the non-working one was an ex-ettin lair. Save (demonstrates confused NPCs, missing Legends mode adventurer on retire, no crash): http://dffd.bay12games.com/file.php?id=14578

Note

Date Modified	Username	Field	Change
2019-10-21 20:57	Shonai_Dweller	New Issue
2019-10-24 19:30	Shonai_Dweller	Note Added: 0039555
2019-10-24 22:04	Shonai_Dweller	Note Added: 0039556
2019-10-26 07:37	Loci	Relationship added	child of 0007559