View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002587 | Dwarf Fortress | Technical -- Saving/Loading | public | 2010-07-07 15:46 | 2023-11-21 05:03 |
| Reporter | SeveQ | Assigned To | lethosor | ||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | confirmed | Resolution | open | ||
| Product Version | 0.31.08 | ||||
| Summary | 0002587: Saving fails silently when folder is not writeable (due to full disk, permissions, etc) | ||||
| Description | I've just lost a well running fortress to save game corruption caused by a full harddisk. In my opinion DF should at least tell me that it can't save the game for any reason and give me options to retry saving (after freeing up some space), abort saving completely (means losing the fortress) or return to the fortress. Just silently killing the savegame is kind of irritating. | ||||
| Tags | saving | ||||
| has duplicate | 0003271 | resolved | Logical2u | DF does not check for available diskspace when saving game |
| has duplicate | 0005773 | resolved | Crashes when accepting newly generated world | |
| has duplicate | 0012608 | resolved | lethosor | Missing error handling on disk write failures -- saved state can be lost |
| related to | 0004824 | new | DF doesn't notice if "export image/info" fails due to file system permissions etc | |
| related to | 0002017 | acknowledged | Loci | Using COMPRESSED_SAVES causes save corruption on some systems |
|
|
Thats your problem right there, just remove some stuff off the harddisk or move the DF directory to a different disk, or move stuff on the harddisk to a flash drive. |
|
|
Yeah, sure. My full harddisk causes this. But DF shouldn't silently ignore that and destroy the savegame. Other software that isn't able to save its data to the harddisk due to insufficient space throws error messages at you with the opportunity to correct the problem before the next attempt to save. IMHO DF should do likewise. DF could somehow estimate the size of the savegame the moment the user chooses "Save" from the game menu (might be cumbersome). Or save process could be put before the quit event so that the game is only eventually quit on a successful save. It's really a minor thing that won't appear as long as you keep enough free space on your harddisk. But sometimes, yeah, sometimes, unexpectedly... I've lost a very good turn to that. |
|
|
Considering that Dwarf Fortress, for the very purpose of avoiding savegame corruption if it happens to crash while saving, always saves your game as a copy in the "Current" folder and then, once it has finished, moves it into the appropriate region folder (after deleting the previous contents), I'd say that it should absolutely be handling this situation more gracefully. |
|
|
I had ths happen recently, it is quite annoying to loose season because of simple oversight. Autosave with autobackup eats up disk space steadily. Lack of disk space definitelly calls for some kind of soluton other than "crash df" or "corrupt savegame". |
|
|
Still occurs in v0.40.24. |
|
|
Still no error handling on filesystem API calls in v50.11 No error handling on disk writes is especially concerning... Disk write failures can happen for many reasons: disk/partition is full, lack of write permissions issue with the "save" folder, disk is network attached and lost its mount (becomes read-only on intermittent network issue), etc. Reproducible Scenario: An easy way to reproduce a disk write failure is to change the permissions of the "save" folder so the current user does not have write access -- then create a new world, and save/exit back to the main menu. Notice that there is no warning in the user interface letting the user know that there was a problem writing the state to disk, and the save folder remains empty. Suggest implementing a modal popup notifying the user of the failure to save the game's state to disk (with all the details), and provide user with options to either "Retry" or "Ignore" the failure. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-07-07 15:46 | SeveQ | New Issue | |
| 2010-07-10 14:19 | SeveQ | Tag Attached: saving | |
| 2010-07-10 15:55 | smjjames | Note Added: 0009892 | |
| 2010-07-22 05:28 | SeveQ | Note Added: 0010810 | |
| 2010-09-18 09:37 | Quietust | Note Added: 0012791 | |
| 2010-09-18 09:38 | Quietust | Note Edited: 0012791 | |
| 2010-09-18 10:44 | Logical2u | Relationship added | has duplicate 0003271 |
| 2011-11-04 03:15 | zwei | Note Added: 0018942 | |
| 2014-01-21 19:55 |
|
Relationship added | has duplicate 0005773 |
| 2014-01-21 19:56 |
|
Relationship added | related to 0004824 |
| 2014-01-21 19:57 |
|
Summary | DF silently fails to save game when disk is full => DF silently fails to save game when folder is not writeable (due to full disk, permissions, etc) |
| 2014-01-21 19:57 |
|
Summary | DF silently fails to save game when folder is not writeable (due to full disk, permissions, etc) => Saving fails silently when folder is not writeable (due to full disk, permissions, etc) |
| 2015-06-29 12:38 | Loci | Note Added: 0032822 | |
| 2015-06-29 13:32 | lethosor | Assigned To | => lethosor |
| 2015-06-29 13:32 | lethosor | Status | new => confirmed |
| 2015-06-29 13:33 | lethosor | Relationship added | related to 0002017 |
| 2023-11-19 15:22 | lethosor | Relationship added | has duplicate 0012608 |
| 2023-11-21 05:03 | c0reDump | Note Added: 0041884 |
