View Issue Details

IDProjectCategoryView StatusLast Update
0003071Dwarf FortressMaterial Propertiespublic2012-03-17 07:13
ReporterQuietust Assigned ToToady One  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.31.12 
Fixed in Version0.31.22 
Summary0003071: All hardcoded materials (glass etc) have uninitialized MAX_EDGE and ABSORPTION and crappy yield/fracture/strain values
DescriptionIn an attempt to determine the various material properties of green glass, clear glass, and crystal glass, I've discovered that the game fails to initialize their MAX_EDGE values at all, resulting in them being mostly random each time you begin a game.

Using a memory viewer, one run in Arena mode resulted in green glass having max edge 102, clear glass having 1, and crystal glass having 93, while another run had 0 for green glass, 2 for clear glass, and 507 for crystal glass. In the data for the various metal types, the value is being set correctly.

On a related note, the physical properties for glass all seem to be placeholder values - all of the YIELD and FRACTURE values are 10000 and all of the STRAIN_AT_YIELD values are 0.
Additional InformationThis may explain the observation in 0002813 that glass trap components are ineffective.
TagsNo tags attached.

Relationships

related to 0004108 new Mussels and oysters lack any material based on PEARL_TEMPLATE, despite having the [PEARL] token 
parent of 0002813 resolvedToady One Glass weapons (in traps) are comically ineffective 
related to 0003612 resolvedToady One Banditry default leads to rampant dwarf/elf banditry 
related to 0004058 new Forgotten Beasts/Demons of certain materials are far too weak. 
related to 0003498 new Some hardcoded materials are unrealistically immune to heat/cold 
related to 0004050 resolvedToady One Plants stored in large glass pots are not used by jobs, and other irregularities with pots 

Activities

Quietust

2010-08-19 13:04

reporter   ~0011929

This assumes that MAX_EDGE is used when determining the amount of damage inflicted by EDGE attacks (which it ought to), as opposed to only the YIELD/FRACTURE/STRAIN values.

Quietust

2010-09-08 12:42

reporter   ~0012517

Last edited: 2010-09-08 12:44

Further memory hacking seems to indicate that ALL of the hardcoded materials ("rock", amber, coral, green glass, clear glass, crystal glass, water, coal, potash, ash, pearlash, lye, mud, vomit, salt, brown filth, yellow filth, unknown substance, and grime) have an undefined MAX_EDGE, though in practice this only affects glass. They also all seem to use the same yield/fracture/strain values of 10000/10000/0, which may cause titans/demons/forgotten beasts made of these materials to be less dangerous than they ought to be.

Beeskee

2010-09-08 15:43

reporter   ~0012519

You are a god.

And, just so I actually contribute something useful to the bug report, I've seen glass be pretty useless in several of my forts. I'm actually using the uselessness as part of a weapon design now.

Quietust

2011-02-22 06:36

reporter   ~0015393

Last edited: 2011-03-07 09:33

It should be noted that ABSORPTION is also uninitialized, which means that glass jugs and pots will frequently be unusable for liquid storage.

Issue History

Date Modified Username Field Change
2010-08-19 12:37 Quietust New Issue
2010-08-19 13:04 Quietust Note Added: 0011929
2010-08-19 17:52 Logical2u Relationship added related to 0002813
2010-09-08 12:42 Quietust Note Added: 0012517
2010-09-08 12:44 Quietust Note Edited: 0012517
2010-09-08 15:43 Beeskee Note Added: 0012519
2010-11-19 06:48 user6 Relationship added related to 0003612
2011-02-22 06:36 Quietust Note Added: 0015393
2011-02-22 07:10 user6 Summary Glass's MAX_EDGE is uninitialized => Glass's MAX_EDGE and ABSORPTION are uninitialized
2011-02-23 07:19 user6 Relationship added related to 0004058
2011-03-02 09:36 user6 Summary Glass's MAX_EDGE and ABSORPTION are uninitialized => All hardcoded materials (glass etc) have uninitialized MAX_EDGE and ABSORPTION
2011-03-02 09:37 user6 Relationship added related to 0003498
2011-03-02 09:38 user6 Relationship replaced parent of 0002813
2011-03-02 09:38 user6 Relationship added related to 0004108
2011-03-02 09:38 user6 Sticky Issue No => Yes
2011-03-02 09:39 user6 Summary All hardcoded materials (glass etc) have uninitialized MAX_EDGE and ABSORPTION => All hardcoded materials (glass etc) have uninitialized MAX_EDGE and ABSORPTION and crappy yield/fracture/strain values
2011-03-06 19:31 user6 Relationship added related to 0004054
2011-03-07 09:33 Quietust Note Edited: 0015393
2011-03-09 04:05 Toady One Status new => resolved
2011-03-09 04:05 Toady One Fixed in Version => 0.31.22
2011-03-09 04:05 Toady One Resolution open => fixed
2011-03-09 04:05 Toady One Assigned To => Toady One
2011-03-09 11:26 user6 Relationship added related to 0004050
2011-03-09 11:26 user6 Relationship deleted related to 0004054
2012-03-17 07:13 user11 Sticky Issue Yes => No