View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006026 | Dwarf Fortress | Dwarf Mode -- Jobs, Smelting | public | 2012-06-15 08:51 | 2015-03-03 17:32 |
| Reporter | Quietust | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | confirmed | Resolution | open | ||
| Product Version | 0.34.11 | ||||
| Summary | 0006026: Melting coins creates too much metal | ||||
| Description | Minting a stack of 500 coins costs 1 bar of metal. Melting that stack down at a smelter, however, yields 1.1 bars - melting 10 stacks of coins nets 11 bars. This seems to be due to a rounding error - the code takes the item's stack size, divides it by 50, then adds 1, meaning a stack of 500 coins yields 11/10 bars when melted. | ||||
| Steps To Reproduce | 1. Mint 10 stacks of coins, using 10 bars of metal 2. Melt down those 10 stacks of coins at a smelter 3. Observe that the smelter now contains 11 bars of metal | ||||
| Additional Information | I originally discovered this while annotating a disassembly of version 0.23.130.23a, so this bug dates back quite a long time. | ||||
| Tags | No tags attached. | ||||
|
|
The simplest solution to this problem would be to subtract 1 from the stack size before performing the division - since an item can never have a stack size of zero, this should work as intended. This problem technically also exists with ammo (99 bolts would give 1 bar, 100 bolts would give 1.1 bars), but it's not an issue since forging metal bolts only gives you a stack of 25. |
|
|
There are several other item types which melt down to yield exactly the same amount of metal that was needed to make them: chains, instruments, animal traps, and buckets. Interestingly, buckets have had a 1 bar melt yield ever since 0.23.130.23a (and possibly earlier), while the others only yielded 0.5 bars prior to 0.34.06. |
|
|
Confirmed still present in 0.40.12 |
|
|
This problem does exist with bolts. |
|
|
jwoodward48df: just like I said in my original comment above... |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-06-15 08:51 | Quietust | New Issue | |
| 2012-06-15 08:53 | Quietust | Note Added: 0023015 | |
| 2012-06-15 13:51 | Quietust | Note Added: 0023021 | |
| 2012-06-15 13:52 |
|
Relationship added | related to 0006027 |
| 2012-06-16 08:01 | Quietust | Note Edited: 0023021 | |
| 2012-06-22 17:14 | Quietust | Note Edited: 0023021 | |
| 2014-09-15 17:33 | Quietust | Note Added: 0030206 | |
| 2014-09-15 17:50 |
|
Assigned To | => user6 |
| 2014-09-15 17:50 |
|
Status | new => confirmed |
| 2014-09-23 19:16 |
|
Relationship added | related to 0008339 |
| 2015-03-03 07:35 | jwoodward48df | Note Added: 0032316 | |
| 2015-03-03 17:32 | Quietust | Note Added: 0032320 |
