View Issue Details

IDProjectCategoryView StatusLast Update
0006841Dwarf FortressVegetationpublic2014-12-29 20:36
Reporterbagofholding Assigned Tolethosor  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionduplicate 
Product Version0.40.01 
Summary0006841: Brewing items without seeds causes items with no name to appear in the still
DescriptionBrewing muck root (and maybe a few others) causes items with no description to appear in the still. These will stay there and not be moved to a food stockpile. They may be cooked in a kitchen and will result in making roasts with no descriptions besides "roast" with "minced minced minced" etc.

The entries in the RAW do not have a seed description entry.
Additional InformationThis is likely related to this bug: 0006750
TagsNo tags attached.

Relationships

duplicate of 0006750 resolvedToady One Muck root and bloated tuber seeds are displayed without a name (e.g. " [9]") 
related to 0001556 new If a MATERIAL_REACTION_PRODUCT references a nonexistent mat in LOCAL_CREATURE_MAT, it silently picks another mat (no errorlog) 

Activities

Kanddak

2014-08-08 09:51

reporter   ~0028588

Can confirm I experienced this. The nameless item showed up in my stocks screen as a seed.

Quietust

2014-08-08 10:12

reporter   ~0028589

Last edited: 2014-08-08 10:14

The brewing reactions produce seeds by using [PRODUCT:100:1:SEEDS:NONE:GET_MATERIAL_FROM_REAGENT:plant:SEED_MAT], but seedless plants don't have a MATERIAL_REACTION_PRODUCT named SEED_MAT, so the item ends up with no material. For most items, this would result in an "unknown material [item]", but seeds get their name from the plant gloss, which is invalid in this case (since it's not made from a plant material).

Either reactions need to be smart enough to skip creation of products with no materials, or reaction products need to gain the ability to become conditional on reagent properties (e.g. [REAGENT_HAS_MATERIAL_REACTION_PRODUCT:plant:SEED_MAT]).

walberg

2014-09-13 12:40

reporter   ~0030169

This appears to be caused by the fact that in plant_standard, muck roots and bloated tubers now seem to have [MATERIAL_REACTION_PRODUCT:SEED_MAT:LOCAL_PLANT_MAT:SEED], but do not have a corresponding [USE_MATERIAL_TEMPLATE:SEED:SEED_TEMPLATE] or [SEED:...] entry. Commenting the MATERIAL_REACTION_PRODUCT bit out causes the issue to go away.

Ultimately it's just a workaround, but it gets rid of the related crash (Linux 0.40.10, at least) when the "nothing" seeds are later used for cooking or something...

Sivarty

2014-10-05 22:16

reporter   ~0030546

Still happening in my current game wich was migrated from 0.40.12 to 0.40.13 during previous reclaim.
Seeds were in still by still till reclaim. Save is centered on there current location.
Here is a save.
http://dffd.wimbli.com/file.php?id=9866

lethosor

2014-12-29 20:36

manager   ~0031559

As far as I can tell, this is a duplicate of 0006750. Please reopen this report or PM me on the forums if this is not the case.

Issue History

Date Modified Username Field Change
2014-07-09 10:01 bagofholding New Issue
2014-07-09 10:21 user6 Relationship added related to 0006750
2014-07-14 17:22 user6 Relationship added has duplicate 0007296
2014-07-14 18:53 user6 Relationship added has duplicate 0007304
2014-07-16 17:05 user6 Relationship added related to 0007399
2014-07-16 17:07 user6 Relationship deleted related to 0007399
2014-08-08 09:14 user6 Assigned To => user6
2014-08-08 09:14 user6 Status new => confirmed
2014-08-08 09:51 Kanddak Note Added: 0028588
2014-08-08 10:12 Quietust Note Added: 0028589
2014-08-08 10:14 Quietust Note Edited: 0028589
2014-08-08 10:36 user6 Relationship added related to 0001556
2014-08-12 11:21 user11 Relationship replaced parent of 0006750
2014-08-21 12:32 user6 Relationship added has duplicate 0008106
2014-09-13 12:40 walberg Note Added: 0030169
2014-10-05 22:16 Sivarty Note Added: 0030546
2014-12-29 20:36 lethosor Note Added: 0031559
2014-12-29 20:36 lethosor Relationship replaced duplicate of 0006750
2014-12-29 20:36 lethosor Status confirmed => resolved
2014-12-29 20:36 lethosor Resolution open => duplicate
2014-12-29 20:36 lethosor Assigned To user6 => lethosor
2014-12-29 20:36 lethosor Relationship deleted has duplicate 0007296
2014-12-29 20:37 lethosor Relationship deleted has duplicate 0007304
2014-12-29 20:37 lethosor Relationship deleted has duplicate 0008106