View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008571 | Dwarf Fortress | Dwarf Mode -- Trade | public | 2014-11-21 06:45 | 2017-06-02 11:46 |
| Reporter | Quietust | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | acknowledged | Resolution | open | ||
| Product Version | 0.40.18 | ||||
| Summary | 0008571: Plant oil soap does not imply plant kill, can be safely traded to Elves | ||||
| Description | In previous versions of Dwarf Fortress (namely, 0.28.181.40d and earlier), soap implied both plant and animal kills due to the usage of Lye (made from wood) and Tallow (made from animals), and both of these could potentially sour trade negotiations (though since ethics were introduced, Elves stopped caring about animal kills). As of version 0.31, however, soap is only flagged with [IMPLIES_ANIMAL_KILL] (which means vanilla elves won't mind trading it), and plant soap (introduced in 0.31.19) has no trade restrictions at all (so nobody will possibly be offended by it). As of version 0.43.05, tallow soap is being handled properly (turns out it just checks for BARs made of any CREATURE_MAT or histfig material), but plant oil soap is definitely not being rejected as it should be. Both plant and animal soap should probably be given a new [IMPLIES_PLANT_KILL] flag, along with the other wood-derived materials - charcoal, ash, lye, potash, and pearlash, but not coke (which may result in other difficulties, since coke and charcoal currently use the same material definition). | ||||
| Tags | Intentional/Expected? | ||||
|
|
Haha, the dwarves simply haven't revealed the hideous truth of how soap is made. ;) |
|
|
I've just checked version 0.43.05, and while I've discovered that tallow soap is being handled properly (turns out it just checks for BARs made of any CREATURE_MAT or histfig material), plant oil soap is definitely not being rejected as it should be. |
|
|
Not a bug, elves don't react to cloth or plant food last I checked. It's WOOD they react to. Behavior is solely linked to the [WOOD] material definition token. |
|
|
Wrong - Elves explicitly object to Ash (which is made by burning wood) as well as Lye, Potash, and Pearlash (which are made from Ash) and Tallow Soap (which is made from Lye). Plant oil soap should still be rejected, not because it is plant-derived, but because it is still made using Lye. |
|
|
Hmm. That sounds like hardcoded fuckery, yeah. I was actually thinking about plant oil soap, I forgot that lye was the thing here. |
|
|
In any event, the summary and description should probably be modified to say that only plant oil soap currently has this problem - I assumed that tallow soap was also affected, but the game apparently already had a special hardcoded check for it (which might be beneficial to replace with one linked to raws). |
|
|
That likely confirms that there's a hardcoded check for the material tallow-based soap is made from, with no added check for plant soap since the check likely predates its addition. Separating the "implies plant kill" from the [WOOD] token, and applying it to ash-derived materials (removing any hardcoded checks involved) would likely be the most efficient method. This would also benefit modders if they're after making playable elves, via allowing wooden materials that lack this tag but still have full usability as wood. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-11-21 06:45 | Quietust | New Issue | |
| 2014-11-22 06:47 | ptb_ptb | Note Added: 0031113 | |
| 2014-11-24 07:06 |
|
Tag Attached: Intentional/Expected? | |
| 2017-05-28 20:31 | Quietust | Note Added: 0036571 | |
| 2017-05-29 10:23 | chaosvolt | Note Added: 0036572 | |
| 2017-05-29 10:25 | chaosvolt | Note Edited: 0036572 | |
| 2017-05-29 10:46 | Quietust | Note Added: 0036573 | |
| 2017-05-29 14:55 | chaosvolt | Note Added: 0036575 | |
| 2017-06-01 16:35 | Quietust | Note Added: 0036582 | |
| 2017-06-01 17:45 | Loci | Status | new => acknowledged |
| 2017-06-01 17:45 | Loci | Summary | Soap does not imply plant kill, can be safely traded to Elves => Plant oil soap does not imply plant kill, can be safely traded to Elves |
| 2017-06-01 17:45 | Loci | Description Updated | |
| 2017-06-02 11:46 | chaosvolt | Note Added: 0036585 |
