View Issue Details

IDProjectCategoryView StatusLast Update
0000423Dwarf FortressDwarf Mode -- Interface, Military Screenpublic2015-01-03 08:48
ReporterDraco18s Assigned Touser6 
PrioritylowSeverityminorReproducibilityalways
Status confirmedResolutionopen 
OSWindowsOS Version7 
Product Version0.31.01 
Summary0000423: Leather Armor Material Type
DescriptionYou can set the material type allowed for uniforms on leather armor. Setting it to "leather" dictates that dwarves wear "leather leather armor."
Steps To ReproduceApply a material type to a [material] armor uniform item.
Additional InformationI would wager that you could do "metal leather armor" and "leather metal armor" too.
Tagstext, Uniform

Relationships

related to 0001300 confirmeduser6 Can't specify wood, bone or shell items in uniforms 
related to 0001995 new No way to specify woven adamantine clothing in uniforms 

Activities

derigo

2010-05-20 14:36

reporter   ~0007092

I don't think this is a bug. "Leather leather armor" means an item of the type 'leather armor' made out of any kind of leather, as opposed to say cow leather leather armor. I realize there is an 'any material' option which effectively does the same thing, but thats ok. That only happens because its such a specific item to begin with(it can only be made out of leather).

And no, you can't specify 'metal leather armor' because the item leather armor has the [LEATHER] token. It can neither be made out of metal nor specified to be metal in the materials assignments. Nor can you make it out of adamantine or shell.

user6

2010-05-20 14:49

  ~0007094

This is still a bug in my opinion, if only because that screen is misusing [MATERIAL_PLACEHOLDER:leather] (see item_armor.txt). It should only use the placeholder when the material is completely ambiguous, but on this screen, it's using it alongside a material category, resulting in the awkward "leather leather".

derigo

2010-05-20 15:02

reporter   ~0007095

Oh I see what you mean. There's no such thing as leather armor, really. Its just called 'armor' with the material placeholder in front. Yea I agree, the placeholder should be replaced by the material, unless the material is completely unspecified.

user8971

2015-01-02 19:14

  ~0031649

Still in 40.23. There is both "armor" and "leather armor" in "A: Armor" category of [m]-[n] uniforms screen. There should be just the first one, the second one should be done only through the combination of Armor: "armor" and Material: "leather".

Rafal99

2015-01-02 21:04

reporter   ~0031652

Last edited: 2015-01-02 21:06

"armor" in "A: Armor" category means any item worn on upper body, just like "headwear" in "H: Helm" category means any headwear.
So "armor" and "leather armor" are different options.

There is a potential problem, such that "armor" with material set to "leather" will probably look the same as "leather armor" with no material set, but will have different meaning. Both with accept "leather leather armor", but the first one will also accept leather shirts or the like, while the second one won't.

user8971

2015-01-03 08:48

  ~0031662

Sure, "armor" and "leather armor" are different options. And yes, "leather armor" and "leather"+"armor" look the same.

The main problem here IMO is that material part is offered out of Material section of uniform settings. I don't know about any such thing there so I think "leather armor" should be removed from Armor options. As it is now, it is not systematic.

Add Note

Note

Issue History

Date Modified Username Field Change
2010-04-04 15:09 Draco18s New Issue
2010-04-04 16:37 Qloos Tag Attached: text
2010-04-04 16:37 Qloos Tag Attached: Uniform
2010-05-20 11:37 user6 Relationship added related to 0001995
2010-05-20 14:36 derigo Note Added: 0007092
2010-05-20 14:49 user6 Note Added: 0007094
2010-05-20 15:02 derigo Note Added: 0007095
2011-03-21 12:58 user6 Relationship added related to 0001300
2015-01-02 19:14 user8971 Note Added: 0031649
2015-01-02 19:50 user6 Assigned To => user6
2015-01-02 19:50 user6 Status new => confirmed
2015-01-02 21:04 Rafal99 Note Added: 0031652
2015-01-02 21:05 Rafal99 Note Edited: 0031652
2015-01-02 21:05 Rafal99 Note Edited: 0031652
2015-01-02 21:06 Rafal99 Note Edited: 0031652
2015-01-03 08:48 user8971 Note Added: 0031662